Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to generalized color recipes, mostly from Fluent UI #5470

Conversation

bheston
Copy link
Collaborator

@bheston bheston commented Dec 15, 2021

Pull Request

📖 Description

As part of the visual refresh, taking the opportunity to move to the generalized recipes we put in place in the latest Fluent UI update. This supports the longer-term goal of externalizing as much of the design system utilities as possible,

👩‍💻 Reviewer Notes

Most recipes updates directly swap and produce the same values. Some recipes will change color values slightly, but this was expected as part of the visual refresh anyway.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a breaking change, are we planning to do this as part of the visual refresh major version release?

@bheston
Copy link
Collaborator Author

bheston commented Feb 8, 2022

Since this is a breaking change, are we planning to do this as part of the visual refresh major version release?

@EisenbergEffect, yes, that was my intent. I have it going into the feature branch. Given the recent work and conversations about shared design system recipes though, I think it would be best to put this work into a new fast-design package. If someone could set the shell of that up in the repo I could move things around in this PR. To be clear, it would be highly generalized recipes we think commonly benefit the community through configuration. + @chrisdholt

@chrisdholt
Copy link
Member

Since this is a breaking change, are we planning to do this as part of the visual refresh major version release?

@EisenbergEffect, yes, that was my intent. I have it going into the feature branch. Given the recent work and conversations about shared design system recipes though, I think it would be best to put this work into a new fast-design package. If someone could set the shell of that up in the repo I could move things around in this PR. To be clear, it would be highly generalized recipes we think commonly benefit the community through configuration. + @chrisdholt

I'm wondering if we should discuss an abstraction for these. Approving as the work needs to be done regardless, but I want to kick the conversation off as we recently have had A LOT of interest in consuming the recipes as well as creating custom ones...

@bheston bheston force-pushed the feature/fast-component-update-visuals branch 2 times, most recently from 62db906 to 511051c Compare March 17, 2022 20:14
* update visual on accordion and accordion-item style

* fixed icons in high contrast white

* optimized svg. removed font styles in accordion

* removed double lines between accordion

* update dividers, adjust padding and format design system
…nents (#5440)

* updatete number field styles. add input style file to pattern. add a input fill design token

* add text field and text area and update input styles

* updated up and down SVG
* udpated select styles and add flyout design token

* optimized SVG and set fillColor targeting listbox

* format

* update open state. adjust neutralStrokeInputFilledFocusDelta

* refactor high contrast styles. update calc on padding and set class to public

* update caret SVG
@bheston bheston force-pushed the users/bheston/general-color-recipes branch from fd9cd65 to cbc6ade Compare March 17, 2022 20:38
@bheston bheston force-pushed the users/bheston/general-color-recipes branch from cbc6ade to 6827028 Compare March 17, 2022 20:56
@bheston bheston merged commit 6996f67 into feature/fast-component-update-visuals Mar 17, 2022
@bheston bheston deleted the users/bheston/general-color-recipes branch March 17, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants