-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to generalized color recipes, mostly from Fluent UI #5470
Updated to generalized color recipes, mostly from Fluent UI #5470
Conversation
332fd20
to
4e5dd9e
Compare
1a561af
to
fd9cd65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a breaking change, are we planning to do this as part of the visual refresh major version release?
@EisenbergEffect, yes, that was my intent. I have it going into the feature branch. Given the recent work and conversations about shared design system recipes though, I think it would be best to put this work into a new fast-design package. If someone could set the shell of that up in the repo I could move things around in this PR. To be clear, it would be highly generalized recipes we think commonly benefit the community through configuration. + @chrisdholt |
packages/web-components/fast-components/src/color/recipes/contrast-and-delta-swatch-set.ts
Outdated
Show resolved
Hide resolved
I'm wondering if we should discuss an abstraction for these. Approving as the work needs to be done regardless, but I want to kick the conversation off as we recently have had A LOT of interest in consuming the recipes as well as creating custom ones... |
62db906
to
511051c
Compare
* update visual on accordion and accordion-item style * fixed icons in high contrast white * optimized svg. removed font styles in accordion * removed double lines between accordion * update dividers, adjust padding and format design system
…nents (#5440) * updatete number field styles. add input style file to pattern. add a input fill design token * add text field and text area and update input styles * updated up and down SVG
* udpated select styles and add flyout design token * optimized SVG and set fillColor targeting listbox * format * update open state. adjust neutralStrokeInputFilledFocusDelta * refactor high contrast styles. update calc on padding and set class to public * update caret SVG
fd9cd65
to
cbc6ade
Compare
cbc6ade
to
6827028
Compare
Pull Request
📖 Description
As part of the visual refresh, taking the opportunity to move to the generalized recipes we put in place in the latest Fluent UI update. This supports the longer-term goal of externalizing as much of the design system utilities as possible,
👩💻 Reviewer Notes
Most recipes updates directly swap and produce the same values. Some recipes will change color values slightly, but this was expected as part of the visual refresh anyway.
✅ Checklist
General
$ yarn change