Revert "[XCUITests] Table View Cell tests" #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1339ed0.
|
Could you explain why you're reverting? |
sophialee0416
approved these changes
Jan 25, 2023
joannaquu
added a commit
that referenced
this pull request
Jan 25, 2023
* Skip failing date picker tests (#1495) * Fix BadgeField space bug (#1497) * attempt to fix space bug * add comment * [XCUITests] Activity Indicator tests (#1493) * initial activity indicator tests * add transition to dark mode * whitespace change * add dark mode color assert * add default color to identifier * update comment * add dark mode + update to use .* * add #if DEBUG * add #if DEBUG to SceneDelegate * add constants * add type * change to hex code * removing color tests * Revert "removing color tests" This reverts commit 79c20c0. * removing color tests again * remove SceneDelegate change * small change * make code more readable + have SwiftUI inherit from UIKit * remove super * [XCUITests] Indeterminate Progress Bar tests (#1503) * add indeterminate progress bar tests * update SwiftUI to inherit from UIKit * remove super * resolve comments * [XCUITests] Table View Cell tests (#1508) * add table view cell tests * move single line asserts to function * add comment * Revert "[XCUITests] Table View Cell tests (#1508)" (#1511) This reverts commit 1339ed0. * Bumping FluentUI version (0.11.0) #1512 Co-authored-by: Lamine Male <106181067+laminesm@users.noreply.github.com> Co-authored-by: Sophia Lee <sophia.lee0416@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1508
Reverting the Table View Cells tests as they seem to be failing nondeterministically (when merged into main,
testSelectionandtestTripleLinefailed the first time, and then passed when reran; when merged into #1504, all table view cell tests excepttestLaunchfailed).Microsoft Reviewers: Open in CodeFlow