Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fluent2-tokens] Merging main -> fluent2-tokens #1515

Merged
merged 8 commits into from
Jan 25, 2023
Merged

[fluent2-tokens] Merging main -> fluent2-tokens #1515

merged 8 commits into from
Jan 25, 2023

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Jan 25, 2023 •
edited by microsoft-github-policy-service bot
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

Binary change:

File Before After Delta
libFluentUI.a 32,536,240 bytes 32,539,272 bytes 3,032 bytes

Changes to tests: #1495, #1493, #1503
Bug fix: #1497
0.11: #1512

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

laminesm and others added 8 commits January 17, 2023 17:51
@laminesm
Skip failing date picker tests (microsoft#1495)
7491109
@joannaquu
Fix BadgeField space bug (microsoft#1497)
45131f6 
* attempt to fix space bug

* add comment
@joannaquu
[XCUITests] Activity Indicator tests (microsoft#1493)
cfce4de 
* initial activity indicator tests

* add transition to dark mode

* whitespace change

* add dark mode color assert

* add default color to identifier

* update comment

* add dark mode + update to use .*

* add #if DEBUG

* add #if DEBUG to SceneDelegate

* add constants

* add type

* change to hex code

* removing color tests

* Revert "removing color tests"

This reverts commit 79c20c0.

* removing color tests again

* remove SceneDelegate change

* small change

* make code more readable + have SwiftUI inherit from UIKit

* remove super
@joannaquu
[XCUITests] Indeterminate Progress Bar tests (microsoft#1503)
8872ab6 
* add indeterminate progress bar tests

* update SwiftUI to inherit from UIKit

* remove super

* resolve comments
@joannaquu
[XCUITests] Table View Cell tests (microsoft#1508)
1339ed0 
* add table view cell tests

* move single line asserts to function

* add comment
@joannaquu
Revert "[XCUITests] Table View Cell tests (microsoft#1508)" (microsof…
2ec7f3e 
…t#1511)

This reverts commit 1339ed0.
@sophialee0416
Bumping FluentUI version (0.11.0) microsoft#1512
d4be314
@joannaquu
Merge branch 'main' into joannaqu/merge-main-tokens
ec5a483
@joannaquu joannaquu requested review from a team as code owners January 25, 2023 22:06
@joannaquu joannaquu merged commit c9cd9b2 into microsoft:fluent2-tokens Jan 25, 2023
@joannaquu joannaquu deleted the joannaqu/merge-main-tokens branch January 25, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrieshin harrieshin harrieshin approved these changes

@sophialee0416 sophialee0416 sophialee0416 approved these changes

@edjamesmsft edjamesmsft edjamesmsft approved these changes

@huwilkes huwilkes huwilkes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@joannaquu @harrieshin @sophialee0416 @edjamesmsft @huwilkes @laminesm