Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XCUITests] Table View Cell tests #1508

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Jan 23, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Binary change:

File Before After Delta
libFluentUI.a 28,875,336 bytes 28,875,336 bytes 0 bytes

Added targeted UI tests for Table View Cell. An accessibility identifier was added to TableViewCell in debug that tracks the title, subtitle (if applicable), footer (if applicable), and accessory views (unread dot, leading images, trailing images). testSelection tests that selecting the single line cells will add an unread dot and that deselecting them will remove the unread dot. All other tests ensure that each cell has the correct accessibility identifier (with emphasis on each cell's accessory views.)

Verification

Simulator Screen Recording - iPhone 14 Pro - 2023-01-23 at 14 27 09

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)

@joannaquu joannaquu marked this pull request as ready for review January 23, 2023 23:02
@joannaquu joannaquu requested a review from a team as a code owner January 23, 2023 23:02
@joannaquu joannaquu merged commit 1339ed0 into microsoft:main Jan 24, 2023
joannaquu added a commit that referenced this pull request Jan 24, 2023
joannaquu added a commit that referenced this pull request Jan 25, 2023
joannaquu added a commit that referenced this pull request Jan 25, 2023
* Skip failing date picker tests (#1495)

* Fix BadgeField space bug (#1497)

* attempt to fix space bug

* add comment

* [XCUITests] Activity Indicator tests (#1493)

* initial activity indicator tests

* add transition to dark mode

* whitespace change

* add dark mode color assert

* add default color to identifier

* update comment

* add dark mode + update to use .*

* add #if DEBUG

* add #if DEBUG to SceneDelegate

* add constants

* add type

* change to hex code

* removing color tests

* Revert "removing color tests"

This reverts commit 79c20c0.

* removing color tests again

* remove SceneDelegate change

* small change

* make code more readable + have SwiftUI inherit from UIKit

* remove super

* [XCUITests] Indeterminate Progress Bar tests (#1503)

* add indeterminate progress bar tests

* update SwiftUI to inherit from UIKit

* remove super

* resolve comments

* [XCUITests] Table View Cell tests (#1508)

* add table view cell tests

* move single line asserts to function

* add comment

* Revert "[XCUITests] Table View Cell tests (#1508)" (#1511)

This reverts commit 1339ed0.

* Bumping FluentUI version (0.11.0) #1512

Co-authored-by: Lamine Male <106181067+laminesm@users.noreply.github.com>
Co-authored-by: Sophia Lee <sophia.lee0416@gmail.com>
@joannaquu joannaquu deleted the joannaqu/table-view-cell-tests branch February 6, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants