Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BasePicker] onBlur prop isn't used #4000

Closed
martellaj opened this issue Feb 16, 2018 · 3 comments · Fixed by #4131
Closed

[BasePicker] onBlur prop isn't used #4000

martellaj opened this issue Feb 16, 2018 · 3 comments · Fixed by #4131
Labels
Type: Bug 🐛

Comments

@martellaj
Copy link
Member

Bug Report

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? No

Requested priority: Normal

Describe the issue:

There's a onBlur prop for BasePicker, but it doesn't seem to be respected. I looked at the BasePicker code, and I can't find any reference to it. Was it recently removed from component code, but not from the props interface? If so, was that intentional?
@martellaj
Copy link
Member Author

@joschect I know you've done picker stuff recently. Aware of any changes that might be related?

@joschect
Copy link
Contributor

It looks like it was added here 741bf74#diff-c88a174b6c194e2d439942d05cb8fb6c but never used. I don't believe it was removed recently.

@mbratukha
Copy link
Contributor

It seems like this event has never been raised.
Any updates when it will be fixed?

mbratukha added a commit to mbratukha/office-ui-fabric-react that referenced this issue Feb 28, 2018
@mbratukha
BasePicker: Fix not used onBlur callback of inputProps (microsoft#4000)
c2540a1
@mbratukha mbratukha mentioned this issue Feb 28, 2018
Merged
2 tasks
dzearing pushed a commit that referenced this issue Mar 2, 2018
@mbratukha @dzearing
BasePicker: Fix not used onBlur callback of inputProps (#4000) (#4131)
4efa90a
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this issue Mar 4, 2018
@Markionium
Merge branch 'master' into no-unused-variable
87f78c7 
* master: (30 commits)
  Addressing Issue microsoft#4147 - Nav Buttons have invalid `aria-describedby` value (microsoft#4159)
  Fix issue 3608: DetailsList horizontal scroll (microsoft#4164)
  Update package.json
  Image SCSS to MergeStyles Part 2: Style Conversion (microsoft#4151)
  Applying package updates.
  [SpinButton] Consistent styles to Button and TextField (microsoft#4098)
  ChoiceGroup: Flex layout for image and icon options (microsoft#4137)
  Initial set of Keytips work in experiments (microsoft#4062)
  Updating tsconfig in button bundle.
  BaseExtendedPicker: Create contextmenu for renderedItem, fix auto focus (microsoft#3954)
  Dropdown: Custom render options for multiselect - Bug fix microsoft#3571  (microsoft#3589)
  Fix documentcard theming (microsoft#4155)
  BasePicker: Fix not used onBlur callback of inputProps (microsoft#4000) (microsoft#4131)
  Allow Elements as Callout targets (microsoft#4134)
  CommandBar: Fixed null commandItemWidths (microsoft#4136)
  add check for when this.suggestionElement may be undefined (microsoft#4157)
  Addressing Issue microsoft#4143 - is-selected missing on ms-Nav-link (microsoft#4158)
  Aria selected (microsoft#4161)
  Move fabric to TypeScript 2.7.2 (microsoft#4153)
  Updating SearchBox examples to have the removed string in placeholder prop.
  ...
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this issue Mar 5, 2018
@Markionium
Merge branch 'master' into polyfill-react-createRef
b43ce33 
* master: (51 commits)
  Applying package updates.
  No unused variable (microsoft#4173)
  Use correct _list ref string (microsoft#4168)
  Nav: wire a link to expand/collapse behavior if it has no URL but has children (microsoft#4171)
  Addressing Issue microsoft#4147 - Nav Buttons have invalid `aria-describedby` value (microsoft#4159)
  Fix issue 3608: DetailsList horizontal scroll (microsoft#4164)
  Update package.json
  Image SCSS to MergeStyles Part 2: Style Conversion (microsoft#4151)
  Applying package updates.
  [SpinButton] Consistent styles to Button and TextField (microsoft#4098)
  ChoiceGroup: Flex layout for image and icon options (microsoft#4137)
  Initial set of Keytips work in experiments (microsoft#4062)
  Updating tsconfig in button bundle.
  BaseExtendedPicker: Create contextmenu for renderedItem, fix auto focus (microsoft#3954)
  Dropdown: Custom render options for multiselect - Bug fix microsoft#3571  (microsoft#3589)
  Fix documentcard theming (microsoft#4155)
  BasePicker: Fix not used onBlur callback of inputProps (microsoft#4000) (microsoft#4131)
  Allow Elements as Callout targets (microsoft#4134)
  CommandBar: Fixed null commandItemWidths (microsoft#4136)
  add check for when this.suggestionElement may be undefined (microsoft#4157)
  ...
chrismohr pushed a commit to chrismohr/office-ui-fabric-react that referenced this issue Apr 17, 2018
@mbratukha
BasePicker: Fix not used onBlur callback of inputProps (microsoft#4000)…
4015ffb 
… (microsoft#4131)
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Type: Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BasePicker: call onBlur callback if it is defined in inputProps mbratukha/office-ui-fabric-react
3 participants
@martellaj @mbratukha @joschect