Move fabric to TypeScript 2.7.2 #4153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AWESOME, thanks @christiango !!! |
dzearing
reviewed
Mar 2, 2018
|
|
||
| // tslint:disable-next-line:no-any | ||
| private _classNameToArgs: { [key: string]: { args: any, rules: string[] } }; | ||
| private _classNameToArgs!: { [key: string]: { args: any, rules: string[] } }; |
There was a problem hiding this comment.
not sure why these were needed.
There was a problem hiding this comment.
Strict initialization check is now enabled
dzearing
approved these changes
Mar 2, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Mar 4, 2018
* master: (30 commits) Addressing Issue microsoft#4147 - Nav Buttons have invalid `aria-describedby` value (microsoft#4159) Fix issue 3608: DetailsList horizontal scroll (microsoft#4164) Update package.json Image SCSS to MergeStyles Part 2: Style Conversion (microsoft#4151) Applying package updates. [SpinButton] Consistent styles to Button and TextField (microsoft#4098) ChoiceGroup: Flex layout for image and icon options (microsoft#4137) Initial set of Keytips work in experiments (microsoft#4062) Updating tsconfig in button bundle. BaseExtendedPicker: Create contextmenu for renderedItem, fix auto focus (microsoft#3954) Dropdown: Custom render options for multiselect - Bug fix microsoft#3571 (microsoft#3589) Fix documentcard theming (microsoft#4155) BasePicker: Fix not used onBlur callback of inputProps (microsoft#4000) (microsoft#4131) Allow Elements as Callout targets (microsoft#4134) CommandBar: Fixed null commandItemWidths (microsoft#4136) add check for when this.suggestionElement may be undefined (microsoft#4157) Addressing Issue microsoft#4143 - is-selected missing on ms-Nav-link (microsoft#4158) Aria selected (microsoft#4161) Move fabric to TypeScript 2.7.2 (microsoft#4153) Updating SearchBox examples to have the removed string in placeholder prop. ...
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Mar 4, 2018
This reverts commit 77c1e54.
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Mar 4, 2018
This reverts commit 573ff2e.
dzearing
pushed a commit
that referenced
this pull request
Mar 5, 2018
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* Rush generate * First wave of fixes * Make merge styles compile * Fix fabric react for ts-2-7 * Fix todo-app * Fix styles of classNamesFunctions * Rush change
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* Revert "Move fabric to TypeScript 2.7.2 (microsoft#4153)" This reverts commit 77c1e54. * Revert "Revert "Move fabric to TypeScript 2.7.2 (microsoft#4153)"" This reverts commit 573ff2e. * No unused variable * Add npm change file * Enable rule
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Upgrades Fabric to TypeScript 2.7.2. The biggest change here is that we had to update the typings for mergeStyleSets. Tested that it is backwards compat with 2.6.2 against the office-online codebase. Though the new typings for mergeStyleSets are more correct than the old ones, so it may cause build breaks for consumers in the event that you aren't passing in all the required parameters for an interface into mergeStyleSets
An example that used to work, but now correctly compiles into an error is the following: