fix: Use correct target windows for ResizeObserver #29551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates all instance of ResizeObserver in react-components to be created from the correct window global. The enforcement is not in the scope of this PR and is already in progress in microsoft#28887. Fixes microsoft#29509
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 13 | 9 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 651 | 651 | 5000 | |
| Button | mount | 308 | 308 | 5000 | |
| Field | mount | 1130 | 1144 | 5000 | |
| FluentProvider | mount | 699 | 698 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 66 | 70 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 77 | 68 | 10 | |
| InfoButton | mount | 13 | 9 | 5000 | Possible regression |
| MakeStyles | mount | 840 | 854 | 50000 | |
| Persona | mount | 1782 | 1730 | 5000 | |
| SpinButton | mount | 1467 | 1367 | 5000 |
🕵 fluentuiv9 No visual regressions between this PR and main |
layershifter
approved these changes
Oct 17, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9c2abd3:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8f2eb85fcde38ad239b1defcb0914263d01c2534 (build) |
ling1726
commented
Oct 18, 2023
packages/react-components/react-virtualizer/src/utilities/createResizeObserverFromDocument.ts
Show resolved
Hide resolved
bsunderhus
approved these changes
Oct 18, 2023
Mitch-At-Work
approved these changes
Oct 18, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 24, 2023
* master: (48 commits) fix(react-drawer): regression with mountNode prop not available after refactoring (microsoft#29524) feat(react-storybook-addon-codesandbox): support various providers for "export to" functionality (microsoft#29536) feat(TimePicker-compat): call onTimeSelect on blur (microsoft#29597) feat: (breadcrumb) Removed appearance prop (microsoft#29554) chore(deps): bump fsevents from 1.2.9 to 1.2.13 (microsoft#29476) Adding comment in Hovercard that we support cumulative area chart currently (microsoft#29395) applying package updates applying package updates chore(vr-tests-react-components, perf-tests-app): Remove infobutton from vr-tests and perf test app (microsoft#29603) docs: Add guidance for modifying textarea's height. (microsoft#29601) fix(react-calendar-compat): Classnames removed and added to day cells need to be split instead of providing a string with spaces (microsoft#29611) [Part 2] Changes to onboard charting to fluent docsite (microsoft#29608) chore: bump jest to 29.7.0 (microsoft#29298) applying package updates feat(react-infolabel, react-components): Release InfoLabel to stable (microsoft#29585) feat(react-datepicker-compat): Update DatePicker to use react-calendar-compat (microsoft#29587) feat: adds motion to DialogSurface (microsoft#29391) fix: Use correct target windows for ResizeObserver (microsoft#29551) chg (microsoft#29592) Fix missing x callout custom callout (microsoft#29547) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all instance of ResizeObserver in react-components to be created from the correct window global. The enforcement is not in the scope of this PR and is already in progress in #28887.
Fixes #29508