disallow all globals in Fluent v9 #30967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spmonahan
requested review from
tomi-msft,
a team and
Mitch-At-Work
as code owners
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 85 | 80 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 37 | 32 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 627 | 611 | 5000 | |
| Button | mount | 305 | 301 | 5000 | |
| Field | mount | 1107 | 1098 | 5000 | |
| FluentProvider | mount | 712 | 700 | 5000 | |
| FluentProviderWithTheme | mount | 85 | 80 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 37 | 32 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 75 | 10 | |
| MakeStyles | mount | 874 | 853 | 50000 | |
| Persona | mount | 1767 | 1682 | 5000 | |
| SpinButton | mount | 1397 | 1350 | 5000 | |
| SwatchPicker | mount | 1528 | 1532 | 5000 |
15 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| LoaderMinimalPerf.default | 186 | 184 | 1.01:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 105 | 85 | 1.24:1 |
| FormMinimalPerf.default | 235 | 207 | 1.14:1 |
| AttachmentMinimalPerf.default | 87 | 77 | 1.13:1 |
| TextMinimalPerf.default | 209 | 189 | 1.11:1 |
| AttachmentSlotsPerf.default | 645 | 605 | 1.07:1 |
| ButtonOverridesMissPerf.default | 681 | 635 | 1.07:1 |
| HeaderMinimalPerf.default | 212 | 198 | 1.07:1 |
| ProviderMergeThemesPerf.default | 683 | 641 | 1.07:1 |
| BoxMinimalPerf.default | 201 | 189 | 1.06:1 |
| ButtonSlotsPerf.default | 320 | 303 | 1.06:1 |
| StatusMinimalPerf.default | 400 | 379 | 1.06:1 |
| CarouselMinimalPerf.default | 279 | 266 | 1.05:1 |
| ChatWithPopoverPerf.default | 200 | 190 | 1.05:1 |
| LabelMinimalPerf.default | 214 | 203 | 1.05:1 |
| TextAreaMinimalPerf.default | 298 | 285 | 1.05:1 |
| AlertMinimalPerf.default | 164 | 157 | 1.04:1 |
| DividerMinimalPerf.default | 206 | 199 | 1.04:1 |
| DropdownManyItemsPerf.default | 398 | 384 | 1.04:1 |
| FlexMinimalPerf.default | 158 | 152 | 1.04:1 |
| HeaderSlotsPerf.default | 472 | 455 | 1.04:1 |
| InputMinimalPerf.default | 565 | 541 | 1.04:1 |
| RefMinimalPerf.default | 114 | 110 | 1.04:1 |
| LayoutMinimalPerf.default | 201 | 195 | 1.03:1 |
| SplitButtonMinimalPerf.default | 2308 | 2230 | 1.03:1 |
| ToolbarMinimalPerf.default | 548 | 531 | 1.03:1 |
| TooltipMinimalPerf.default | 1317 | 1273 | 1.03:1 |
| AnimationMinimalPerf.default | 302 | 297 | 1.02:1 |
| ListCommonPerf.default | 391 | 383 | 1.02:1 |
| ListNestedPerf.default | 317 | 310 | 1.02:1 |
| MenuMinimalPerf.default | 511 | 501 | 1.02:1 |
| PortalMinimalPerf.default | 85 | 83 | 1.02:1 |
| ProviderMinimalPerf.default | 209 | 204 | 1.02:1 |
| CustomToolbarPrototype.default | 1504 | 1472 | 1.02:1 |
| CardMinimalPerf.default | 304 | 301 | 1.01:1 |
| CheckboxMinimalPerf.default | 1149 | 1143 | 1.01:1 |
| ListMinimalPerf.default | 308 | 306 | 1.01:1 |
| PopupMinimalPerf.default | 350 | 347 | 1.01:1 |
| RadioGroupMinimalPerf.default | 264 | 261 | 1.01:1 |
| ReactionMinimalPerf.default | 215 | 213 | 1.01:1 |
| SegmentMinimalPerf.default | 193 | 192 | 1.01:1 |
| IconMinimalPerf.default | 393 | 388 | 1.01:1 |
| TableMinimalPerf.default | 234 | 232 | 1.01:1 |
| AvatarMinimalPerf.default | 109 | 109 | 1:1 |
| EmbedMinimalPerf.default | 1855 | 1852 | 1:1 |
| SliderMinimalPerf.default | 745 | 747 | 1:1 |
| TableManyItemsPerf.default | 1111 | 1106 | 1:1 |
| VideoMinimalPerf.default | 439 | 438 | 1:1 |
| DatepickerMinimalPerf.default | 3574 | 3613 | 0.99:1 |
| DialogMinimalPerf.default | 432 | 435 | 0.99:1 |
| DropdownMinimalPerf.default | 1421 | 1439 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 703 | 712 | 0.99:1 |
| MenuButtonMinimalPerf.default | 945 | 959 | 0.99:1 |
| TreeMinimalPerf.default | 491 | 494 | 0.99:1 |
| ChatMinimalPerf.default | 430 | 440 | 0.98:1 |
| ListWith60ListItems.default | 366 | 373 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 149 | 154 | 0.97:1 |
| RosterPerf.default | 1552 | 1609 | 0.96:1 |
| SkeletonMinimalPerf.default | 192 | 201 | 0.96:1 |
| GridMinimalPerf.default | 188 | 197 | 0.95:1 |
| ImageMinimalPerf.default | 215 | 228 | 0.94:1 |
| AccordionMinimalPerf.default | 78 | 85 | 0.92:1 |
| ButtonMinimalPerf.default | 89 | 99 | 0.9:1 |
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 630 | 629 | 5000 | |
| Breadcrumb | mount | 1659 | 1693 | 1000 | |
| Checkbox | mount | 1709 | 1703 | 5000 | |
| CheckboxBase | mount | 1482 | 1488 | 5000 | |
| ChoiceGroup | mount | 3007 | 2955 | 5000 | |
| ComboBox | mount | 690 | 667 | 1000 | |
| CommandBar | mount | 6439 | 6364 | 1000 | |
| ContextualMenu | mount | 11429 | 11645 | 1000 | |
| DefaultButton | mount | 795 | 797 | 5000 | |
| DetailsRow | mount | 2122 | 2268 | 5000 | |
| DetailsRowFast | mount | 2215 | 2212 | 5000 | |
| DetailsRowNoStyles | mount | 2037 | 2067 | 5000 | |
| Dialog | mount | 2657 | 2660 | 1000 | |
| DocumentCardTitle | mount | 219 | 231 | 1000 | |
| Dropdown | mount | 2024 | 1967 | 5000 | |
| FocusTrapZone | mount | 1146 | 1133 | 5000 | |
| FocusZone | mount | 1083 | 1094 | 5000 | |
| GroupedList | mount | 41357 | 41771 | 2 | |
| GroupedList | virtual-rerender | 18147 | 20127 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51051 | 56161 | 2 | |
| GroupedListV2 | mount | 234 | 228 | 2 | |
| GroupedListV2 | virtual-rerender | 214 | 215 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 234 | 245 | 2 | |
| IconButton | mount | 1117 | 1138 | 5000 | |
| Label | mount | 346 | 339 | 5000 | |
| Layer | mount | 2773 | 2768 | 5000 | |
| Link | mount | 407 | 406 | 5000 | |
| MenuButton | mount | 993 | 1001 | 5000 | |
| MessageBar | mount | 21336 | 21380 | 5000 | |
| Nav | mount | 2041 | 2036 | 1000 | |
| OverflowSet | mount | 787 | 800 | 5000 | |
| Panel | mount | 1809 | 1777 | 1000 | |
| Persona | mount | 767 | 762 | 1000 | |
| Pivot | mount | 915 | 898 | 1000 | |
| PrimaryButton | mount | 910 | 929 | 5000 | |
| Rating | mount | 4699 | 4647 | 5000 | |
| SearchBox | mount | 932 | 930 | 5000 | |
| Shimmer | mount | 1921 | 1896 | 5000 | |
| Slider | mount | 1351 | 1325 | 5000 | |
| SpinButton | mount | 2948 | 2968 | 5000 | |
| Spinner | mount | 381 | 385 | 5000 | |
| SplitButton | mount | 1907 | 1850 | 5000 | |
| Stack | mount | 410 | 410 | 5000 | |
| StackWithIntrinsicChildren | mount | 857 | 857 | 5000 | |
| StackWithTextChildren | mount | 2643 | 2682 | 5000 | |
| SwatchColorPicker | mount | 6435 | 6309 | 5000 | |
| TagPicker | mount | 1522 | 1482 | 5000 | |
| Text | mount | 374 | 377 | 5000 | |
| TextField | mount | 969 | 978 | 5000 | |
| ThemeProvider | mount | 853 | 838 | 5000 | |
| ThemeProvider | virtual-rerender | 588 | 593 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1284 | 1311 | 5000 | |
| Toggle | mount | 590 | 635 | 5000 | |
| buttonNative | mount | 201 | 189 | 5000 |
khmakoto
approved these changes
Apr 4, 2024
Hotell
reviewed
Apr 5, 2024
packages/react-components/react-toast/src/components/AriaLive/useAriaLive.ts
Outdated
Show resolved
Hide resolved
Hotell
reviewed
Apr 5, 2024
spmonahan
force-pushed
the
chore/disallow-globals
branch
from
bc07a69
to
3c2baf4
Compare
spmonahan
commented
Apr 19, 2024
packages/react-components/react-virtualizer/src/components/Virtualizer/useVirtualizer.ts
Outdated
Show resolved
Hide resolved
spmonahan
commented
Apr 19, 2024
packages/react-components/react-virtualizer/src/components/Virtualizer/useVirtualizer.ts
Outdated
Show resolved
Hide resolved
1 task
spmonahan
force-pushed
the
chore/disallow-globals
branch
from
222c36a
to
0e46844
Compare
spmonahan
force-pushed
the
chore/disallow-globals
branch
from
fa0e312
to
4fe758c
Compare
spmonahan
commented
May 10, 2024
change/@fluentui-eslint-plugin-ea97d70f-085e-47bb-a6ac-6faba3f09cfc.json
Show resolved
Hide resolved
Hotell
reviewed
May 15, 2024
packages/react-components/priority-overflow/src/createResizeObserver.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-utilities/src/hooks/useTimeout.ts
Outdated
Show resolved
Hide resolved
fabricteam
reviewed
May 15, 2024
change/@fluentui-eslint-plugin-ea97d70f-085e-47bb-a6ac-6faba3f09cfc.json
Show resolved
Hide resolved
khmakoto
approved these changes
May 17, 2024
This allows scrollIntoView to reference the correct window when calling "getComputedStyle()".
spmonahan
force-pushed
the
chore/disallow-globals
branch
from
545ac96
to
6253fe4
Compare
fabricteam
reviewed
May 22, 2024
change/@fluentui-eslint-plugin-ea97d70f-085e-47bb-a6ac-6faba3f09cfc.json
Show resolved
Hide resolved
fabricteam
reviewed
May 22, 2024
change/@fluentui-eslint-plugin-ea97d70f-085e-47bb-a6ac-6faba3f09cfc.json
Show resolved
Hide resolved
Mitch-At-Work
approved these changes
May 22, 2024
packages/react-components/react-aria/src/activedescendant/scrollIntoView.ts
Show resolved
Hide resolved
packages/react-components/react-aria/src/activedescendant/scrollIntoView.ts
Show resolved
Hide resolved
layershifter
approved these changes
May 23, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 28, 2024
* master: (49 commits) Update focus order in sankey chart for vertical navigation (microsoft#31469) chore: use new performant 'type-check' for v9 libaries (microsoft#31454) applying package updates fix(Timepicker-compat): clearIcon not working in freeform (microsoft#31324) chore: re-enable lint rule (microsoft#31459) feat(react-tag-picker): adds text property to TagPickerOption (microsoft#31474) feat(recipes): create package with initial implementation (moved from /apps) (microsoft#31386) applying package updates applying package updates chore: revert globals changes (microsoft#31470) (web-components) Use `ElementInternals` for TextInput elements (microsoft#31201) chore:(docs) Update and migrate component implementation guide (microsoft#31398) disallow all globals in Fluent v9 (microsoft#30967) chore:(react-nav-preview) Recomposing more components and some pixel pushing (microsoft#31387) fix(pr-deploy-site): explicitly set types to not include whole @types/* globals which are causing issues with addition of @types/web (microsoft#31465) fix(recipes-react-components): explicitly set types to not include whole @types/* globals which are cauising issues with addition of @types/web (microsoft#31463) applying package updates applying package updates applying package updates Update IconDirectionContextProvider import to import from specific path (microsoft#31006) ...
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Code could directly access globals like
setTimeoutandclearTimeout.New Behavior
Code cannot directly access any globals (i.e., properties of
window) and must get them from Fluent context (useFluent()).Most of the code changes in this PR should probably use useAnimationFrame() and useTimeout() but I wanted to minimize change for this PR so I've created #30968 to follow up.
Related Issue(s)