chore:(react-nav-preview) Recomposing more components and some pixel pushing #31387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
mltejera
force-pushed
the
another-recomposition-non-drawer-components
branch
from
8c4a248
to
71498a3
Compare
|
I would also change Person icon to Person20Regular/Filled. |
mltejera
force-pushed
the
another-recomposition-non-drawer-components
branch
3 times, most recently
from
73ca07b
to
9b08913
Compare
|
There seems to be an issue with the hamburger. when the nav is open and then you close it by clicking the hamburger, the hamburger doesn't wait for the animations to finish before showing up. Filed a bug accordingly until there's a path exposed to coordinate the button appearing and drawer closing events better. |
GeoffCoxMSFT
approved these changes
May 23, 2024
mltejera
force-pushed
the
another-recomposition-non-drawer-components
branch
from
866fd30
to
c3a4403
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 28, 2024
* master: (49 commits) Update focus order in sankey chart for vertical navigation (microsoft#31469) chore: use new performant 'type-check' for v9 libaries (microsoft#31454) applying package updates fix(Timepicker-compat): clearIcon not working in freeform (microsoft#31324) chore: re-enable lint rule (microsoft#31459) feat(react-tag-picker): adds text property to TagPickerOption (microsoft#31474) feat(recipes): create package with initial implementation (moved from /apps) (microsoft#31386) applying package updates applying package updates chore: revert globals changes (microsoft#31470) (web-components) Use `ElementInternals` for TextInput elements (microsoft#31201) chore:(docs) Update and migrate component implementation guide (microsoft#31398) disallow all globals in Fluent v9 (microsoft#30967) chore:(react-nav-preview) Recomposing more components and some pixel pushing (microsoft#31387) fix(pr-deploy-site): explicitly set types to not include whole @types/* globals which are causing issues with addition of @types/web (microsoft#31465) fix(recipes-react-components): explicitly set types to not include whole @types/* globals which are cauising issues with addition of @types/web (microsoft#31463) applying package updates applying package updates applying package updates Update IconDirectionContextProvider import to import from specific path (microsoft#31006) ...
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…pushing (microsoft#31387) Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com> Co-authored-by: Esteban Munoz <estebanmu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recomposing NavSectionHeader and Hamburger. Removing HamburgerInNav as it's no longer necessary.
General pixel pushing.
Before:
https://github.com/microsoft/fluentui/assets/17346018/e0711b1a-cbb9-4601-8518-2fc2e40b5c2b
After:
https://github.com/microsoft/fluentui/assets/17346018/94aeb274-76d2-4ff6-ab7d-69da796d1d51
Ladders to #26649