Skip to content

Conversation

khmakoto
Copy link
Member

@khmakoto khmakoto commented May 6, 2019

…nt potential breaks.

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

Adding @uifabric/experiments as a dependency in test-bundles to prevent potential breaks.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull-requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me and give me an instruction to get started! Learn more here.

@khmakoto
Copy link
Member Author

khmakoto commented May 6, 2019

@msft-github-bot wait 1 minute

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Mon, 06 May 2019 21:16:14 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@msft-github-bot
Copy link
Contributor

Component perf results:

Scenario Target branch avg total (ms) PR avg total (ms) Target branch avg per item (ms) PR avg per item (ms)
PrimaryButton 101.201 101.787 1.012 1.018
BaseButton 35.733 36.508 0.357 0.365
NewButton 118.008 136.709 1.180 1.367
button 5.361 6.850 0.054 0.068
DetailsRows without styles 202.357 197.376 2.024 1.974
DetailsRows 202.009 213.033 2.020 2.130
Toggles 51.614 53.681 0.516 0.537
NewToggle 72.419 70.916 0.724 0.709
DocumentCardTitle with truncation 24.020 ... 0.240 ...

@micahgodbolt micahgodbolt mentioned this pull request May 6, 2019
37 tasks
@msft-github-bot msft-github-bot merged commit 3f43333 into microsoft:fabric-7 May 6, 2019
@khmakoto khmakoto deleted the testBundlesDep branch May 6, 2019 21:48
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants