Skip to content

Conversation

JyotikaGargg
Copy link
Contributor

@JyotikaGargg JyotikaGargg commented Nov 25, 2022

Description :
OnError Command support in GoSqlCmd
For details refer : https://learn.microsoft.com/en-us/sql/tools/sqlcmd-utility?view=sql-server-ver16

WIP : Adding UTs

Copy link
Contributor

@apoorvdeshmukh apoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some merge conflicts with main branch. Can you resolve that?
Please add unit test case to test this implementation and in combination with -b and -V .

@apoorvdeshmukh
Copy link
Contributor

I just noticed that you are adding unit tests. In that case you can mark the PR as draft till it's ready.

@JyotikaGargg JyotikaGargg changed the title OnError command support in GoSQlCmd [Draft] OnError command support in GoSQlCmd Nov 25, 2022
@JyotikaGargg JyotikaGargg marked this pull request as draft November 25, 2022 07:57
@JyotikaGargg
Copy link
Contributor Author

There seems to be some merge conflicts with main branch. Can you resolve that? Please add unit test case to test this implementation and in combination with -b and -V .

Resolved merge conflicts. And UTs are still WIP

@JyotikaGargg JyotikaGargg reopened this Nov 25, 2022
@shueybubbles
Copy link
Collaborator

  	if err == ErrExitRequested || once {

check if any code that returns ErrExitRequested here should be bound by the new setting to not request exit when :on error ignore has been used.


Refers to: pkg/sqlcmd/sqlcmd.go:148 in 4a16d79. [](commit_id = 4a16d79, deletion_comment = False)

Copy link
Collaborator

@shueybubbles shueybubbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@shueybubbles
Copy link
Collaborator

as you push new commits, resolve the relevant discussions in the PR.

@shueybubbles shueybubbles marked this pull request as ready for review December 8, 2022 15:37
Copy link
Collaborator

@shueybubbles shueybubbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants