Add named pipes and shared memory connections #188
Conversation
.vscode/launch.json
Outdated
| "program": "${workspaceFolder}/cmd/sqlcmd", | ||
| "args" : ["-Q", "EXIT(select 100 as Count)"], | ||
| "program": "${workspaceFolder}/cmd/modern", | ||
| "args" : ["-Q", "EXIT(select network_protocol from sys.dm_exec_sessions)", "-S", "lpc:."], |
There was a problem hiding this comment.
Do we already have a unit test to test this scenario?
There was a problem hiding this comment.
I'm 8 getting unit test failures on my local machine with this branch
=== RUN TestExitOnError
unable to get instances from Sql Server Browser on host localhost: read udp [::1]:63086->[::1]:1434: i/o timeout
sqlcmd_test.go:286:
Error Trace: C:\src\go-sqlcmd\cmd\sqlcmd\sqlcmd_test.go:286
I run with Browser disabled. If I enable browser, then the tests don't fail, but this PR should not require browser service be running moving forward.
We need a unit test to catch this in the future (make sure we don't approve a change that causes browser service running to be a dependency)
Hi @stuartpa , how did you get these test failures? I just ran the tests locally and I all the unit tests passed. Do we need to do something to disable browser service? |
|
net stop "SQL Server Browser" to stop it |
|
the browser dependency will be fixed by tagging go-mssqldb to v0.20.0 and using that build, which has the fix. |
|
I'm going to sit on this PR for a while and work on some higher priority items (like NOTICE generation) and come back to it. |
|
@stuartpa can you confirm I've fixed this on your system? Then I'll merge In reply to: 1245441859 |
Fixes #187
Now that
go-mssqldbsupportsnpandlpcprotocols, so can go-sqlcmd, at least on Windows.