Add localization support for go-sqlcmd #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds localization framework and support for languages en-us, de-de, fr-fr, es-es, pt-br, ko-kr, zh-cn, zh-tw, it-it, ja-jp, ru-ru. Localized text added for de-de, fr-fr and es-es. Subsequqnt commits will add localized text for remaining languages. Translations have been taken from ODBC sqlcmd.rll.lcl for corresponding language.
This commit adds localized text for remaining language tags such as it-it, pt-br, ja-jp, ko-kr, zh-cn, zh-tw, ru-ru.
shueybubbles
reviewed
Feb 8, 2023
shueybubbles
reviewed
Feb 8, 2023
shueybubbles
reviewed
Feb 8, 2023
shueybubbles
reviewed
Feb 8, 2023
shueybubbles
reviewed
Feb 8, 2023
shueybubbles
reviewed
Feb 8, 2023
shueybubbles
reviewed
Feb 8, 2023
shueybubbles
reviewed
Feb 8, 2023
shueybubbles
reviewed
Feb 8, 2023
shueybubbles
reviewed
Feb 8, 2023
This commit addresses review comments and simplifies the localizer package to instantiate only one language printer instance at a time.
|
Are there any pending comments or suggestions? |
|
pls Resolve issues as you fix them. Every comment still shows as "Active" In reply to: 1427551524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds localization framework and support for languages
en-us, de-de, fr-fr, es-es, pt-br, ko-kr, zh-cn, zh-tw, it-it, ja-jp, ru-ru.
Localized text added for de-de, fr-fr and es-es. Subsequqnt commits will
add localized text for remaining languages. Translations have been taken
from ODBC sqlcmd.rll.lcl for corresponding language.