Skip to content

Don't use SQLCMDPASSWORD env var if SQLCMDUSER env var not set #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Don't use SQLCMDPASSWORD env var if SQLCMDUSER env var not set #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions cmd/modern/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,20 @@ func initializeEnvVars() {
if os.Getenv("SQLCMDSERVER") == "" {
os.Setenv("SQLCMDSERVER", server)
}
if os.Getenv("SQLCMDUSER") == "" {
os.Setenv("SQLCMDUSER", username)
}
if os.Getenv("SQLCMDPASSWORD") == "" {
os.Setenv("SQLCMDPASSWORD", password)

// Username and password should come together, either from the environment
// variables set by the user before the sqlcmd process started, or from the sqlconfig
// for the current context, but if just the environment variable SQLCMDPASSWORD
// is set before the process starts we do not use it, if the user and password is set in sqlconfig.
if username != "" && password != "" { // If not trusted auth
if os.Getenv("SQLCMDUSER") == "" {
os.Setenv("SQLCMDUSER", username)
os.Setenv("SQLCMDPASSWORD", password)
}
}

}

}

// isFirstArgModernCliSubCommand is TEMPORARY code, to be removed when
Expand Down