Skip to content

Docker release package #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Docker release package #61

merged 3 commits into from
Apr 20, 2022

Conversation

stuartpa
Copy link
Collaborator

@stuartpa stuartpa commented Mar 24, 2022

This PR builds a Docker image for 'sqlcmd'. To use the docker image simply run (this runs sqlcmd with no args):

docker run --rm microsoft/sqlcmd

Example of how to pass args:

docker run --rm microsoft/sqlcmd sqlcmd --help

The PR is designed to work both directly in the local repo and Azure Dev Ops.

This PR is part of a series of 5 initial PRs that will provide packages for all the common managers on the common OSes (Linux, Windows and Mac). Follow up PRs will provide packages for less common configs.

Execute the following command from the root directory of this repository:

./release/linux/docker/pipeline.sh

Output will be sent to ./output/docker

To test the packages:

./release/linux/docker/pipeline-test.sh

@stuartpa stuartpa force-pushed the stuartpa/package-docker branch from 6e6487b to 3680302 Compare April 20, 2022 16:26
@stuartpa stuartpa marked this pull request as ready for review April 20, 2022 16:30
@@ -32,6 +32,7 @@ steps:
BUILD_OUTPUT: $(Pipeline.Workspace)
BUILD_STAGINGDIRECTORY: $(Build.ArtifactStagingDirectory)
- task: EsrpCodeSigning@1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code signing is going to vary widely per package type. Perhaps we could move each signing profile into its own yml and include the appropriate yml based on the package type. For a docker package the included yml could have a no-op step.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I'm about to run into this with the next PR for Windows .msi.

@stuartpa stuartpa merged commit cbafb93 into main Apr 20, 2022
@stuartpa stuartpa deleted the stuartpa/package-docker branch April 20, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants