Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep one connection open for the lifetime of sqlcmd #71

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Keep one connection open for the lifetime of sqlcmd #71

merged 2 commits into from
Apr 4, 2022

Conversation

shueybubbles
Copy link
Collaborator

Fixes #68

@shueybubbles
Copy link
Collaborator Author

I don't know what the right behavior should be if the connection goes bad. I think as-written it would require the user to use :connect to reconnect.

@shueybubbles shueybubbles merged commit 5b7db7b into main Apr 4, 2022
@shueybubbles shueybubbles deleted the shueybubbles/connectionlifetime branch April 4, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartpa stuartpa stuartpa approved these changes

@kenvanhyning kenvanhyning Awaiting requested review from kenvanhyning

@dzsquared dzsquared Awaiting requested review from dzsquared

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLCMD must stay connected
2 participants
@shueybubbles @stuartpa