defaulting to unbuffered reader for dmverity hashing #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ksayid <khalilsayid@microsoft.com> Signed-off-by: Seth Hollandsworth <sethho@microsoft.com>
anmaxvl
approved these changes
Sep 6, 2023
BryceDFisher
approved these changes
Sep 12, 2023
KenGordon
approved these changes
Sep 13, 2023
helsaawy
approved these changes
Sep 13, 2023
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Sep 14, 2023
Signed-off-by: Seth Hollandsworth <sethho@microsoft.com> Co-authored-by: ksayid <khalilsayid@microsoft.com> (cherry picked from commit e7509cc)
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Sep 14, 2023
Signed-off-by: Seth Hollandsworth <sethho@microsoft.com> Co-authored-by: ksayid <khalilsayid@microsoft.com> (cherry picked from commit e7509cc) Signed-off-by: Maksim An <maksiman@microsoft.com>
Merged
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Sep 20, 2023
Signed-off-by: Seth Hollandsworth <sethho@microsoft.com> Co-authored-by: ksayid <khalilsayid@microsoft.com> (cherry picked from commit e7509cc) Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Sep 20, 2023
Signed-off-by: Seth Hollandsworth <sethho@microsoft.com> Co-authored-by: ksayid <khalilsayid@microsoft.com> (cherry picked from commit e7509cc) Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
pushed a commit
that referenced
this pull request
Sep 20, 2023
Signed-off-by: Seth Hollandsworth <sethho@microsoft.com> Co-authored-by: ksayid <khalilsayid@microsoft.com> (cherry picked from commit e7509cc) Signed-off-by: Maksim An <maksiman@microsoft.com>
helsaawy
pushed a commit
to helsaawy/hcsshim
that referenced
this pull request
Sep 27, 2023
Signed-off-by: Seth Hollandsworth <sethho@microsoft.com> Co-authored-by: ksayid <khalilsayid@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
confcomCLI tooling that uses the dmverity-vhd executable, we were seeing an issue where large OCI images would cause the dmverity hashing process to get killed because the machine ran out of memory: example.This unbuffered option makes go-containerregistry stream in the image as needed instead of loading it all at once, saving memory with the tradeoff of being slower for large images. The typical use case we've seen is to use the
confcomtooling on a local machine or VM with ~16GB of memory so memory efficiency is more important than time efficiency.Discussed with Maksim that making this the default should be fine. thanks!