adding option of using buffered image reader for faster dmverity hashing #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethHollandsworth
force-pushed
the
feature/optional-buffered-dmverity
branch
from
62250ee
to
0ddfcc6
Compare
anmaxvl
reviewed
Feb 1, 2024
cmd/dmverity-vhd/main.go
Outdated
| verboseFlag = "verbose" | ||
| outputDirFlag = "out-dir" | ||
| dockerFlag = "docker" | ||
| bufferedOpenerFlag = "buffered-opener" |
There was a problem hiding this comment.
the sdk we're using calls it opener, I think it would be simpler to keep it as that
There was a problem hiding this comment.
If these are external facing, "reader" makes more sense than "opener".
SethHollandsworth
force-pushed
the
feature/optional-buffered-dmverity
branch
from
0ddfcc6
to
3b10d8e
Compare
Signed-off-by: Seth Hollandsworth <sethho@microsoft.com>
SethHollandsworth
force-pushed
the
feature/optional-buffered-dmverity
branch
from
3b10d8e
to
e49750c
Compare
anmaxvl
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related PR: #1887
We previously set the default to an unbuffered reader for the sake of memory efficiency. This PR adds the option back in to use a buffered reader for users with ample available memory. This allows for faster dmverity hashing if needed.
Testing in a VM with a 1.5GB image, an unbuffered reader uses 1/4 the RAM but takes 3x longer for dmverity hashing (from 20s up to 1m). With a swing that large either way, it would be nice to give users the option to choose which they want for use in the confcom plugin. Thanks!