-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guest support for multi-root workspaces / solutions #46
Comments
Additionally, it would be great to hear feedback about whether folks want to share "loose files" that they open during a collaboration session, but aren't actually part of the shared solution (VS) or workspace (VS Code). |
@Chuxel Any idea where this is on your priority list? |
@lumaxis It's definitely one we know is important. Out of curiosity, what is your use case? Are you In VS or VS Code? |
In the VS App Center team, we are running several Node.js services which are mostly developed using VS Code. Recently, we also moved to one big mono-repo. In the mono-repo, we have several In my team, we also focus on knowledge sharing and try to do pairing and collaboration as much as possible. For those purposes, we recently started using Live Share as a tool, especially for the parts of our team that are remote. |
@lumaxis Yes, that's great info! Makes complete sense. This is definitely on-roadmap and we know it's important for VS solutions so it's great to hear about a concrete scenario like this for VS Code too given workspaces is a new-ish feature in the tool. |
My example use case is converting a React Javascript app to TypeScript so setup a multi-root workspace with both folders that sit side by side to do the conversion. But when Live Sharing came across this issue. |
In my use case I'm trying to share a project built with CMake (Visual Studio as host).
None of the source files appear for a VS Code client, since they're outside the solution folder (i.e. |
Merging in #240 from @mihe, @DJLink Issue from @mihe Product and Version: VS 15.6.4, VS Code 1.22.2 Steps to Reproduce / Scenario:
This creates problems with any project where the Reply from @DJLink I have this same issue. Some extra information, once I start a debug session and put a breakpoint in one of those files outside the project it will show on the other user session too, during that debug session |
Further information for implementation and use-case, I work on a team developing full-stack on our own server and front-end architecture. The way our server runs, each of our products is a separate module, which I have open as separate folders within the workspace to keep from having massive, difficult to navigate file trees. |
@Chuxel What are the state of this issue? Really looking forward for this, collaboration will improve so much when we can use local IDE instead of remote screen sharing. |
Had the same issue, but also found a simple workaround that helped for how we wanted to use it: In visual studio select the solution file you want to share, and then in the file menu select save as. Save the solution file in a higher up directory where everything you need is in, and then for liveshare open that copy of the solution instead. |
This workaround only works for folders that can be co-located unfortunately. I have a workspace mixing golang and node and have no desire to put my javascript in my $GOPATH. |
I've had to make a single folder for live share to work again. Shame this isn't higher up as a priority. |
@jpike88 Apologies for that inconvenience! Not only is this high priority, but we’re actually very close to finishing the work to fully support this. We’ll keep everyone updated on progress in the coming weeks 👍 |
FYI, the latest version of Live Share adds support for multi-root workspaces in VS Code! You should be able to open multiple roots and simply click the We're working on the equivalent support in VS, and will keep everyone posted on progress. Thanks! |
Closing this as resolved, now that support for it has been added to VS 👍 |
Hello, I find for solution in project subdirectory directory(such as ProjectA/win/ProjectA.sln), If I share it by live-share to visual studio code, The visual studio code can only navigate to source files in the solution file directory(e.g: ProjectA/win/ ), the source files in top project directory cannot navigated(elg: ProjectA/src/main.cc). How can I fix this? But if the session is save to another visual studio, I can navigate all the source files referenced by visual studio solution file. Live Share extension version installed inVisual Studio is 1.0.1349.1, Visual Studio version: Microsoft Visual Studio Community 2019 16.4.2. Live Share extension in Visual Studio Code is: 1.0.1404. |
Hi im also still having issues with csproj containing file and when the source is not a subdir of the csproj. |
Hi, is it possible that there has been a regression in this functionality? With the latest version of VSCode, my coworker is only seeing the first folder of the workspace. |
Same. I'm able to workaround it by manually editing the workspace configuration file from the remote VS Code to look something like these for each of the root folders:
The tricky part is knowing which folder is which because you need to know the order of the root folders without being able to see them, and how many there are, etc. It's not ideal but it does work. Unfortunately, you need to repeat the process every time you connect to a live shared workspace. |
See also #4034 |
I'm seeing the same thing. We're looking into it now. Sorry for the delay. |
Should be fixed in the latest release 🎉 |
I'm using VSCode 1.60.2 with Live Share 1.0.4836, released the day @daytonellwanger said this issue should be fixed, and I'm still seeing the problem. The work-around given above of editing the code-workspace did temporarily resolve it for me, but I'm still not able to open files by name from the command bar if they're outside the first folder. That may be a separate issue, though. |
I'm using VSCode 1.61.2, and seeing this problem, I think. Created a code share session and my compatriot is only seeing the first workspace. |
Same issue with both devs on 1.62.0; only 1 of 2 workspace folders is visible on the share |
Only first entry in folders array ( Not complaining, just saying it's weird 😅 |
I also have the same problem, but I might have some insights here. |
Currently Live Share only supports a single root folder.
This feature requests adding these capabilities into Live Share.
The text was updated successfully, but these errors were encountered: