Copilot - code refactor #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
quge009
commented
Sep 5, 2025
quge009
commented
- Backend structure
- copilot service: manage http server, parse/assemble http packets (refactored from 'copilot.py')
- copilot conversation: manage authenticate state, conversation context (renamed from 'copilot.py')
- copilot turn: process each Q/A chat turn (renamed from 'copilot_agent.py')
- Function: Classification
- Seperate code from copilot turn for maintainance
- Config files:
- Add env for restserver api
There was a problem hiding this comment.
Pull Request Overview
A comprehensive refactor of the CoPilot backend architecture that separates concerns into distinct layers and extracts classification functionality for improved maintainability.
- Backend structure refactored with three main components:
CoPilotServicefor HTTP handling,CoPilotConversationfor authentication and conversation context, andCoPilotTurnfor Q/A processing - Classification functionality extracted into a separate
QuestionClassifierclass from the original turn processing - Environment variables added for REST server API authentication and group validation
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/copilot-chat/src/copilot_agent/utils/classify.py | New module containing the extracted QuestionClassifier class |
| src/copilot-chat/src/copilot_agent/utils/init.py | Import addition for the new QuestionClassifier class |
| src/copilot-chat/src/copilot_agent/copilot_turn.py | New module handling individual Q/A turn processing (renamed from copilot_agent.py) |
| src/copilot-chat/src/copilot_agent/copilot_service.py | New module managing HTTP server and API endpoints |
| src/copilot-chat/src/copilot_agent/copilot_conversation.py | New module handling authentication and conversation management |
| src/copilot-chat/src/copilot_agent/main.py | Updated to use new refactored architecture |
| deploy/copilot-chat-deployment.yaml.template | Added environment variables for REST server configuration |
| config/copilot-chat.yaml | Added configuration values for REST server URL and valid groups |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fix bug in config file Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
yukirora
reviewed
Sep 5, 2025
| - name: AGENT_HOST | ||
| value: {{ cluster_cfg["copilot-chat"]["agent-host"] }} | ||
| - name: RESTSERVER_URL | ||
| value: {{ cluster_cfg["copilot-chat"]["restserver-url"] }} |
There was a problem hiding this comment.
value: {{ cluster_cfg['rest-server']['uri'] }}
yukirora
reviewed
Sep 5, 2025
yukirora
reviewed
Sep 5, 2025
| self.msg_dict[user_id] = deque(maxlen=HISTORY_DEPTH) | ||
| self.msg_dict[user_id].append(message) | ||
|
|
||
| def audit_msg_dict(self) -> None: |
yukirora
reviewed
Sep 5, 2025
| in_parameters = InParameters(data) | ||
| return in_parameters | ||
|
|
||
| def collect_data(self, inout: str, parameters: Union[InParameters, OutParameters]) -> None: |
yukirora
reviewed
Sep 5, 2025
| msg_user = {'role': 'user', 'content': user_prompt} | ||
| self.manage_conv_history(user_id, msg_user) | ||
| logger.info(f'[internal control word] [per user check] user "{user_id}" msg_list length is {len(self.msg_dict[user_id])}') | ||
| resp = self.copilot.process_turn(self.msg_dict[user_id], skip_summary, debugging) |
yukirora
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.