Skip to content

Conversation

abuccts
Copy link
Member

@abuccts abuccts commented Sep 16, 2025

Fix GPU and default Ethernet interface detection in job exporter.

Fix GPU and default Ethernet interface detection in job exporter.
@abuccts abuccts added the bug Something isn't working label Sep 16, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes GPU and default Ethernet interface detection in the job exporter by improving hardware detection methods and making Ethernet device configuration more robust.

  • Replaced PCI-based GPU detection with kernel module detection for more accurate GPU identification
  • Added automatic detection of default network interface instead of hardcoding 'eth0'
  • Added safety checks to prevent network monitoring when no Ethernet device is configured

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/job-exporter/src/Moneo/src/worker/exporters/node_exporter.py Added netifaces import, implemented get_default_iface() function, and added ethernet_device validation checks
src/job-exporter/build/moneo-gpu-exporter_entrypoint.sh Changed GPU detection from lspci to lsmod for AMD and NVIDIA graphics cards

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Update according to comment.
@yukirora yukirora merged commit 4302fe7 into release/1.3 Sep 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants