Skip to content

Conversation

bewithgaurav
Copy link
Collaborator

@bewithgaurav bewithgaurav commented Aug 5, 2025

Work Item / Issue Reference

AB#34985

GitHub Issue: #<ISSUE_NUMBER>


Summary

Introducing Alpine Support

@Copilot Copilot AI review requested due to automatic review settings August 5, 2025 12:12
@github-actions github-actions bot added the pr-size: large Substantial code update label Aug 5, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Alpine Linux support to the mssql-python library by resolving circular import issues that occurred during module initialization on Alpine's musl-based system. The key change moves driver path resolution from Python to C++ to avoid importing Python helpers during critical initialization phases.

  • Implemented C++ driver path resolution to replace Python-based approach
  • Added Alpine Linux distribution detection and driver loading support
  • Included comprehensive Alpine ARM64 testing pipeline with containerized environment

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 5 comments.

File Description
mssql_python/pybind/ddbc_bindings.cpp Replaced Python-based driver path resolution with pure C++ implementation including Alpine detection
mssql_python/helpers.py Removed Python helper functions for driver path resolution and Linux distro detection
tests/test_000_dependencies.py Updated tests to use new C++ driver path function and added Alpine detection logic
eng/pipelines/pr-validation-pipeline.yml Added Alpine ARM64 testing pipeline and renamed existing Linux jobs for clarity

@github-actions github-actions bot added pr-size: large Substantial code update and removed pr-size: large Substantial code update labels Aug 5, 2025
@github-actions github-actions bot added pr-size: large Substantial code update and removed pr-size: large Substantial code update labels Aug 5, 2025
@github-actions github-actions bot added pr-size: large Substantial code update and removed pr-size: large Substantial code update labels Aug 5, 2025
@github-actions github-actions bot added pr-size: large Substantial code update and removed pr-size: large Substantial code update labels Aug 5, 2025
@github-actions github-actions bot added pr-size: large Substantial code update and removed pr-size: large Substantial code update labels Aug 5, 2025
@github-actions github-actions bot added pr-size: large Substantial code update and removed pr-size: large Substantial code update labels Aug 6, 2025
@github-actions github-actions bot added pr-size: large Substantial code update and removed pr-size: large Substantial code update labels Aug 6, 2025
@bewithgaurav bewithgaurav merged commit 1c2a895 into main Aug 6, 2025
18 checks passed
@bewithgaurav bewithgaurav linked an issue Aug 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-size: large Substantial code update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Alpine Linux
4 participants