Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Improve performance of TimerRetention #3158

Closed
Porges opened this issue Jun 5, 2023 · 1 comment
Closed

Improve performance of TimerRetention #3158

Porges opened this issue Jun 5, 2023 · 1 comment
Assignees
@Porges
Labels
enhancement New feature or request

Comments

@Porges
Copy link
Member

Porges commented Jun 5, 2023 •
edited by mgreisen
Loading

We are seeing this sometimes take a very long time.

#AB152647
@Porges Porges added the enhancement New feature or request label Jun 5, 2023
@mgreisen mgreisen assigned mgreisen and Porges and unassigned mgreisen Jun 12, 2023
@Porges Porges mentioned this issue Jul 13, 2023
Merged
Porges added a commit that referenced this issue Jul 17, 2023
@Porges
UPN changes/fixes (#3289)
0bac434 
Starts to address #3158.

Rather than storing the UPN and then removing it later, do not store it in the first place.

I found one problem while working on this which was that `UserInfo` was not actually stored on `Job`, so address that as well. This was because properties which are not constructor parameters are not stored by the ORM, so I've also removed other examples from `Task` and `Node` and have them only on the response types.

---

Also started to simplify the ORM roundtripping tests; remove the custom equality comparison and instead simply compare JSON-serialized values. Rely on the FsCheck automatic generation of values where it works, rather than writing a custom Arbitrary which does the same thing.
@Porges
Copy link
Member Author

Porges commented Aug 10, 2023

Closing this as addressed, as of #3289:

image

@Porges Porges closed this as completed Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Porges Porges

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Porges @stishkin @mgreisen