-
Notifications
You must be signed in to change notification settings - Fork 85
[torchlib] [ci] Fix failing external data tests for Windows #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 22 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Test Results 24 files ± 0 24 suites ±0 2h 46m 17s ⏱️ - 1m 4s For more details on these failures and errors, see this check. Results for commit 9b3e82e. ± Comparison against base commit 684b5b5. This pull request removes 2861 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
767604a
to
031f92f
Compare
Could you add a test to verify that calling numpy() etc. on a released external tensor will still work (e.g. we can release and load again at will)? Thanks! |
3a81e6c
to
a5cafd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Windows crashes: Windows fatal exception: access violation https://github.com/microsoft/onnxscript/actions/runs/10693258903/job/29643192895?pr=1834 |
a5cafd7
to
9b3e82e
Compare
Failures seem to be unrelated. |
Fix failing external data tests for Windows due to file permission errors