Skip to content

Conversation

shubhambhokare1
Copy link
Contributor

@shubhambhokare1 shubhambhokare1 commented Aug 29, 2024

Fix failing external data tests for Windows due to file permission errors

@shubhambhokare1 shubhambhokare1 self-assigned this Aug 29, 2024
@shubhambhokare1 shubhambhokare1 added module: torchlib Related to the torch/aten function lib in development broken ci labels Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

❌ 22 Tests Failed:

Tests completed Failed Passed Skipped
12052 22 12030 2021
View the top 3 failed tests by shortest run time
onnxscript.converter_test.TestConverter test_eager_op
Stack Traces | 0.001s run time
No failure message available
onnxscript.converter_test.TestConverter test_loops_break
Stack Traces | 0.001s run time
No failure message available
onnxscript.converter_test.TestConverter test_loops_while
Stack Traces | 0.001s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@shubhambhokare1 shubhambhokare1 marked this pull request as draft August 29, 2024 16:57
Copy link

github-actions bot commented Aug 29, 2024

Test Results

     24 files  ±    0      24 suites  ±0   2h 46m 17s ⏱️ - 1m 4s
 14 073 tests  - 2 860  11 699 ✅  - 2 857    2 338 💤  - 1   32 ❌ ± 0   4 🔥  -  2 
354 978 runs  +    7  81 137 ✅ +   71  273 651 💤 ±0  162 ❌  - 50  28 🔥  - 14 

For more details on these failures and errors, see this check.

Results for commit 9b3e82e. ± Comparison against base commit 684b5b5.

This pull request removes 2861 and adds 1 tests. Note that renamed tests count towards both.
tests.ir.serde_roundtrip_test.SerdeTest ‑ test_serialization_deserialization_produces_same_model_0001_attn_stable_diffusion_unet_0_attn_stable_diffusion_unet_0_onnx
tests.ir.serde_roundtrip_test.SerdeTest ‑ test_serialization_deserialization_produces_same_model_0002_ln_llama2_2_ln_llama2_2_onnx
tests.ir.serde_roundtrip_test.SerdeTest ‑ test_serialization_deserialization_produces_same_model_0003_attn_stable_diffusion_unet_without_encoder_hidden_states_1_attn_stable_diffusion_unet_without_encoder_hidden_states_1_onnx
tests.ir.serde_roundtrip_test.SerdeTest ‑ test_serialization_deserialization_produces_same_model_0004_geglu_stable_diffusion_unet_3_geglu_stable_diffusion_unet_3_onnx
tests.ir.serde_roundtrip_test.SerdeTest ‑ test_serialization_deserialization_produces_same_model_0005_geglu_stable_diffusion_unet_0_geglu_stable_diffusion_unet_0_onnx
tests.ir.serde_roundtrip_test.SerdeTest ‑ test_serialization_deserialization_produces_same_model_0007_attn_phi_1_5_0_attn_phi_1_5_0_onnx
tests.ir.serde_roundtrip_test.SerdeTest ‑ test_serialization_deserialization_produces_same_model_0008_geglu_stable_diffusion_unet_2_geglu_stable_diffusion_unet_2_onnx
tests.ir.serde_roundtrip_test.SerdeTest ‑ test_serialization_deserialization_produces_same_model_0009_gelu_phi_1_5_0_gelu_phi_1_5_0_onnx
tests.ir.serde_roundtrip_test.SerdeTest ‑ test_serialization_deserialization_produces_same_model_0010_attn_phi_1_5_1_attn_phi_1_5_1_onnx
tests.ir.serde_roundtrip_test.SerdeTest ‑ test_serialization_deserialization_produces_same_model_0011_gelu_phi_1_5_3_gelu_phi_1_5_3_onnx
…
onnxscript.ir._core_test.ExternalTensorTest ‑ test_release_does_not_invalidate_tensor

♻️ This comment has been updated with latest results.

@shubhambhokare1 shubhambhokare1 marked this pull request as ready for review August 30, 2024 19:39
@shubhambhokare1 shubhambhokare1 force-pushed the sbhokare/fix-exdata-wintests branch from 767604a to 031f92f Compare September 3, 2024 22:35
@justinchuby
Copy link
Collaborator

justinchuby commented Sep 4, 2024

Could you add a test to verify that calling numpy() etc. on a released external tensor will still work (e.g. we can release and load again at will)? Thanks!

@shubhambhokare1 shubhambhokare1 force-pushed the sbhokare/fix-exdata-wintests branch from 3a81e6c to a5cafd7 Compare September 4, 2024 01:08
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@justinchuby
Copy link
Collaborator

Windows crashes: Windows fatal exception: access violation

https://github.com/microsoft/onnxscript/actions/runs/10693258903/job/29643192895?pr=1834

@shubhambhokare1 shubhambhokare1 force-pushed the sbhokare/fix-exdata-wintests branch from a5cafd7 to 9b3e82e Compare September 4, 2024 19:37
@shubhambhokare1
Copy link
Contributor Author

Windows crashes: Windows fatal exception: access violation

https://github.com/microsoft/onnxscript/actions/runs/10693258903/job/29643192895?pr=1834

Failures seem to be unrelated.

@shubhambhokare1 shubhambhokare1 merged commit 6146f99 into main Sep 4, 2024
23 of 39 checks passed
@shubhambhokare1 shubhambhokare1 deleted the sbhokare/fix-exdata-wintests branch September 4, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

broken ci module: torchlib Related to the torch/aten function lib in development

Projects

Development

Successfully merging this pull request may close these issues.

3 participants