[Optimizer] Avoid accessing None value in _process_constant_node #2513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Berganski <christoph.berganski@gmail.com>
justinchuby
reviewed
Aug 26, 2025
justinchuby
approved these changes
Aug 26, 2025
justinchuby
reviewed
Aug 26, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2513 +/- ##
==========================================
+ Coverage 70.07% 70.10% +0.03%
==========================================
Files 215 215
Lines 25831 25878 +47
Branches 2596 2606 +10
==========================================
+ Hits 18100 18143 +43
- Misses 6833 6836 +3
- Partials 898 899 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Christoph Berganski <christoph.berganski@gmail.com>
Signed-off-by: Christoph Berganski <christoph.berganski@gmail.com>
|
Thanks! Could you fix lint? We can then merge. |
justinchuby
approved these changes
Aug 28, 2025
Signed-off-by: Christoph Berganski <christoph.berganski@gmail.com>
justinchuby
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.