Skip to content

Fix logical op for non-boolean type #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix logical op for non-boolean type #2579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions onnxscript/function_libs/torch_lib/ops/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5025,13 +5025,27 @@ def aten_logical_and(self: BOOL, other: BOOL) -> BOOL:
return op.And(self, other)


@torch_op("aten::logical_and", trace_only=True)
def aten_logical_and_non_bool_type(self: TTensor, other: TTensor2) -> BOOL:
"""logical_and(Tensor self, Tensor other) -> Tensor"""

return op.And(op.Cast(self, to=BOOL.dtype), op.Cast(other, to=BOOL.dtype))


@torch_op(("aten::logical_not", "aten::bitwise_not"), trace_only=True)
def aten_logical_not(self: BOOL) -> BOOL:
"""logical_not(Tensor self) -> Tensor"""

return op.Not(self)


@torch_op("aten::logical_not", trace_only=True)
def aten_logical_not_non_bool_type(self: TTensor) -> BOOL:
"""logical_not(Tensor self) -> Tensor"""

return op.Equal(self, 0)


@torch_op(
(
"aten::logical_or",
Expand All @@ -5049,6 +5063,13 @@ def aten_logical_or(self: BOOL, other: BOOL) -> BOOL:
return op.Or(self, other)


@torch_op("aten::logical_or", trace_only=True)
def aten_logical_or_non_bool_type(self: TTensor, other: TTensor2) -> BOOL:
"""logical_or(Tensor self, Tensor other) -> Tensor"""

return op.Or(op.Cast(self, to=BOOL.dtype), op.Cast(other, to=BOOL.dtype))


@torch_op(
(
"aten::logical_xor",
Expand All @@ -5064,6 +5085,13 @@ def aten_logical_xor(self: BOOL, other: BOOL) -> BOOL:
return op.Xor(self, other)


@torch_op("aten::logical_xor", trace_only=True)
def aten_logical_xor_non_bool_type(self: TTensor, other: TTensor2) -> BOOL:
"""logical_xor(Tensor self, Tensor other) -> Tensor"""

return op.Xor(op.Cast(self, to=BOOL.dtype), op.Cast(other, to=BOOL.dtype))


@torch_op("aten::logit", private=True)
def _aten_logit_onnx(self: TFloat) -> TFloat:
return op.Log(op.Div(self, op.Sub(1.0, self)))
Expand Down