Skip to content

test: use headed instead of headful in CLI args #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2021
Merged

test: use headed instead of headful in CLI args #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/async/test_emulation_focus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ async def test_should_change_document_activeElement(page, server):


async def test_should_not_affect_screenshots(page, server, assert_to_be_golden):
# Firefox headful produces a different image.
# Firefox headed produces a different image.
page2 = await page.context.new_page()
await asyncio.gather(
page.set_viewport_size({"width": 500, "height": 500}),
Expand Down
6 changes: 3 additions & 3 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def assetdir() -> Path:
@pytest.fixture(scope="session")
def launch_arguments(pytestconfig: Any) -> Dict:
return {
"headless": not pytestconfig.getoption("--headful"),
"headless": not pytestconfig.getoption("--headed"),
"channel": pytestconfig.getoption("--browser-channel"),
}

Expand Down Expand Up @@ -181,10 +181,10 @@ def pytest_addoption(parser: Any) -> None:
help="Browser channel to be used.",
)
parser.addoption(
"--headful",
"--headed",
action="store_true",
default=False,
help="Run tests in headful mode.",
help="Run tests in headed mode.",
)


Expand Down