Skip to content

feat: accept pathlib in the API #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Jul 30, 2020

Drive-by standardise the usage of path objects in the project and cleaned up the tests for the __dirname usage.

Lesson learned: if path is a string just wrap it in Path() as usual. It does also work if path is already a Path object.

https://docs.python.org/3/library/pathlib.html

@mxschmitt mxschmitt changed the title cleanup: replaced os.path by pathlib calls feat: accept pathlib in the API Jul 30, 2020
@coveralls
Copy link

coveralls commented Jul 30, 2020

Pull Request Test Coverage Report for Build 189031475

  • 21 of 25 (84.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 87.977%

Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/main.py 5 9 55.56%
Totals Coverage Status
Change from base Build 188830934: 0.06%
Covered Lines: 3205
Relevant Lines: 3643

💛 - Coveralls

@mxschmitt mxschmitt force-pushed the cleanup/pathlib branch 2 times, most recently from 01ca3ce to 849664e Compare July 30, 2020 17:42
@pavelfeldman pavelfeldman merged commit 735c3a2 into microsoft:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants