Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error): display correct message #165

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

mxschmitt
Copy link
Member

Like we do in upstream:

https://github.com/microsoft/playwright/blob/d4c466868b4a82c3be7ebd697698dd9c129af98d/src/errors.ts#L18-L24

Before

>>> message = '''Timeout 30000ms exceeded.\n=========================== logs ===========================\n[api] waiting for selector "[data-testid=dnb-table] tbody tr:nth-child(1):not(.ant-table-placeholder)"\n============================================================\nNote: use DEBUG=pw:api environment variable and rerun to capture Playwright logs.'''
>>> 

stack='''TimeoutError: Timeout 30000ms exceeded.\n=========================== logs ===========================\n[api] waiting for selector "[data-testid=dnb-table] tbody tr:nth-child(1):not(.ant-table-placeholder)"\n============================================================\nNote: use DEBUG=pw:api environment variable and rerun to capture Playwright logs.\n    at ProgressController.run (/snapshot/driver/node_modules/playwright/lib/progress.js:71:30)\n    at Object.runAbortableTask (/snapshot/driver/node_modules/playwright/lib/progress.js:24:23)\n    at Page._runAbortableTask (/snapshot/driver/node_modules/playwright/lib/page.js:89:27)\n    at Frame.waitForSelector (/snapshot/driver/node_modules/playwright/lib/frames.js:443:27)\n    at Frame.waitForSelector (/snapshot/driver/node_modules/playwright/lib/helper.js:80:31)\n    at FrameDispatcher.waitForSelector (
>>> from playwright import Error
>>> 
>>> x = Error(message, stack)
>>> raise(x)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
playwright.helper.Error: ('Timeout 30000ms exceeded.\n=========================== logs ===========================\n[api] waiting for selector "[data-testid=dnb-table] tbody tr:nth-child(1):not(.ant-table-placeholder)"\n============================================================\nNote: use DEBUG=pw:api environment variable and rerun to capture Playwright logs.', 'TimeoutError: Timeout 30000ms exceeded.\n=========================== logs ===========================\n[api] waiting for selector "[data-testid=dnb-table] tbody tr:nth-child(1):not(.ant-table-placeholder)"\n============================================================\nNote: use DEBUG=pw:api environment variable and rerun to capture Playwright logs.\n    at ProgressController.run (/snapshot/driver/node_modules/playwright/lib/progress.js:71:30)\n    at Object.runAbortableTask (/snapshot/driver/node_modules/playwright/lib/progress.js:24:23)\n    at Page._runAbortableTask (/snapshot/driver/node_modules/playwright/lib/page.js:89:27)\n    at Frame.waitForSelector (/snapshot/driver/node_modules/playwright/lib/frames.js:443:27)\n    at Frame.waitForSelector (/snapshot/driver/node_modules/playwright/lib/helper.js:80:31)\n    at FrameDispatcher.waitForSelector (/snapshot/driver/node_modules/playwright/lib/rpc/server/frameDispatcher.js:66:124)\n    at DispatcherConnection.dispatch (/snapshot/driver/node_modules/playwright/lib/rpc/server/dispatcher.js:137:52)\n    at Transport.onmessage (/snapshot/driver/node_modules/playwright/lib/rpc/server.js:35:55)\n    at Immediate.<anonymous> (/snapshot/driver/node_modules/playwright/lib/rpc/transport.js:64:26)\n    at processImmediate (internal/timers.js:456:21)')

After

>>> message = '''Timeout 30000ms exceeded.\n=========================== logs ===========================\n[api] waiting for selector "[data-testid=dnb-table] tbody tr:nth-child(1):not(.ant-table-placeholder)"\n============================================================\nNote: use DEBUG=pw:api environment variable and rerun to capture Playwright logs.'''
>>> 

stack='''TimeoutError: Timeout 30000ms exceeded.\n=========================== logs ===========================\n[api] waiting for selector "[data-testid=dnb-table] tbody tr:nth-child(1):not(.ant-table-placeholder)"\n============================================================\nNote: use DEBUG=pw:api environment variable and rerun to capture Playwright logs.\n    at ProgressController.run (/snapshot/driver/node_modules/playwright/lib/progress.js:71:30)\n    at Object.runAbortableTask (/snapshot/driver/node_modules/playwright/lib/progress.js:24:23)\n    at Page._runAbortableTask (/snapshot/driver/node_modules/playwright/lib/page.js:89:27)\n    at Frame.waitForSelector (/snapshot/driver/node_modules/playwright/lib/frames.js:443:27)\n    at Frame.waitForSelector (/snapshot/driver/node_modules/playwright/lib/helper.js:80:31)\n    at FrameDispatcher.waitForSelector (/snapshot/driver/node_modules/playwright/lib/rpc/server/frameDispatcher.js:66:124)\n    at DispatcherConnection.dispatch (/snapshot/driver/node_modules
... '''
>>> from playwright import Error
>>> 
>>> x = Error(message, stack)
>>> raise(x)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
playwright.helper.Error: Timeout 30000ms exceeded.
=========================== logs ===========================
[api] waiting for selector "[data-testid=dnb-table] tbody tr:nth-child(1):not(.ant-table-placeholder)"
============================================================
Note: use DEBUG=pw:api environment variable and rerun to capture Playwright logs.
>>> 

@mxschmitt mxschmitt merged commit 9364c37 into microsoft:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants