test: migrate flaky plugin to rerunfailures #2772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
migrate-from-flaky-to-rerunfailures
branch
from
c19f37c to
ed48b33
Compare
mxschmitt
commented
Mar 10, 2025
| @@ -49,5 +49,5 @@ jobs: | |||
| docker exec "${CONTAINER_ID}" pip install -r requirements.txt | |||
| docker exec "${CONTAINER_ID}" pip install -e . | |||
| docker exec "${CONTAINER_ID}" python -m build --wheel | |||
| docker exec "${CONTAINER_ID}" xvfb-run pytest -vv tests/sync/ | |||
| docker exec "${CONTAINER_ID}" xvfb-run pytest -vv tests/async/ | |||
| docker exec "${CONTAINER_ID}" xvfb-run pytest tests/sync/ | |||
There was a problem hiding this comment.
drive-by: we set -vv already in our setup.cfg.
yury-s
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our assumption from marking individual tests as flaky to marking the whole test run as flaky and retrying all the tests if needed. It replaces the flaky plugin with rerunfailures plugin (maintained by the pytest org) since its not compatible with each-other. This aligns it how we do it in Node.js.
It enables 3 retries only for CI runs.