Skip to content

tests: added popup tests #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 11, 2020
Merged

tests: added popup tests #39

merged 8 commits into from
Jul 11, 2020

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Jul 10, 2020 •
edited
Loading

addInitScript does not accept a callback function anymore like in JS. ()=>window.foo=true does not work but window.foo=true does work, is this expected?

Hm, quite flaky on firefox and webkit.

@pavelfeldman pavelfeldman merged commit 7df1b61 into microsoft:master Jul 11, 2020
@mxschmitt mxschmitt deleted the tests/popup branch July 11, 2020 09:37
@GunjanSheth GunjanSheth mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxschmitt @pavelfeldman