Skip to content

tests: added download tests and linting #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2020
Merged

tests: added download tests and linting #43

merged 2 commits into from
Jul 11, 2020

Conversation

mxschmitt
Copy link
Member

Changes:

  • Since no typing errors are persistent anymore, I've enforced it in the CI so only valid code will be shipped
  • In VSCode you can use flake8 as a formatter (Seems most common) which I also enforced (but disabled a few rules). But will prevent us from doing bad things. Is integrated nicely in VSCode, GitHub Actions and as a pre-commit hook.
  • Added tests from the downloads.spec.js

ddelange
ddelange reviewed Jul 11, 2020
View reviewed changes
@pavelfeldman pavelfeldman merged commit 81e49ed into microsoft:master Jul 11, 2020
@mxschmitt mxschmitt deleted the tests/download branch July 14, 2020 14:35
@GunjanSheth GunjanSheth mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

+1 more reviewer

@ddelange ddelange ddelange left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxschmitt @pavelfeldman @ddelange