-
Notifications
You must be signed in to change notification settings - Fork 1k
tests: added network tests and refactored test server #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a901d57
to
a3c0e82
Compare
If I modify your script to store the print(await page.evaluate('''async () => {
const response = await window.fooo;
return response.text();
}''')) It never resolves. This suggests that the server does something wrong - it does not work without any Playwright logic... |
… into tests/network
devtools show you request and response (headers), i bet that the preview is empty though, because body was not retrieved. |
pavelfeldman
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is missing and failing / hanging (not included in the PR) in the last line with the await. Not sure why it's not passing. From my understanding the RPC server does not return the request body anymore in this case (saw it in the protocol).