Skip to content

wait for the process #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Mar 22, 2021

fixes #571

when using the async_playwright() context manager early in an asyncio.run program, the proc can be garbage collected after the loop is closed. When proc is garbage collected the underlying transport is then garbage collected, which tries to kill the running process but cannot without a running loop

@pavelfeldman
Copy link
Member

Thanks for the PR! I can imagine writing the test for this could be problematic due to GC, but scoping process to the event loop lifetime makes sense.

@pavelfeldman pavelfeldman merged commit 03e5cd0 into microsoft:master Mar 22, 2021
@graingert graingert deleted the wait-for-process branch March 22, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async API - asyncio error
2 participants