Skip to content

feat(roll): roll Playwright to 1.2.0-next.1595094993390 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2020

Conversation

pavelfeldman
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jul 19, 2020

Pull Request Test Coverage Report for Build 174725563

  • 121 of 123 (98.37%) changed or added relevant lines in 12 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 94.383%

Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/element_handle.py 31 32 96.88%
playwright/network.py 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
playwright/js_handle.py 2 94.34%
Totals Coverage Status
Change from base Build 172139998: 0.3%
Covered Lines: 1445
Relevant Lines: 1531

💛 - Coveralls

Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment, try to avoid dict() use {} instead. Same for list() -> [] . (ref)

LGTM! 👍

@pavelfeldman pavelfeldman merged commit 91c54d9 into microsoft:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants