Skip to content

feat(wait helper): add wait helper for client-side waitFor* methods #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2020
Merged

feat(wait helper): add wait helper for client-side waitFor* methods #74

merged 1 commit into from
Jul 19, 2020

Conversation

pavelfeldman
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jul 19, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 174909570

  • 104 of 105 (99.05%) changed or added relevant lines in 5 files are covered.
  • 15 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.7%) to 93.668%
Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/frame.py 28 29 96.55%
Files with Coverage Reduction New Missed Lines %
playwright/page.py 1 92.04%
playwright/browser_context.py 2 83.9%
playwright/main.py 4 89.47%
playwright/helper.py 8 86.96%
Totals Coverage Status
Change from base Build 174792840: -0.7%
Covered Lines: 1494
Relevant Lines: 1595
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 19, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 174937214

  • 101 of 102 (99.02%) changed or added relevant lines in 5 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.4%) to 93.966%
Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/frame.py 28 29 96.55%
Files with Coverage Reduction New Missed Lines %
playwright/page.py 1 92.01%
playwright/browser_context.py 2 83.9%
playwright/helper.py 8 86.96%
Totals Coverage Status
Change from base Build 174934236: -0.4%
Covered Lines: 1495
Relevant Lines: 1591
💛 - Coveralls

mxschmitt
mxschmitt reviewed Jul 19, 2020
View reviewed changes
playwright/network.py
@@ -58,7 +58,6 @@ def postData(self) -> Optional[str]:
def headers(self) -> Dict[str, str]:
return parse_headers(self._initializer["headers"])

@property
async def response(self) -> Optional["Response"]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed to be the last async property 👍

@pavelfeldman pavelfeldman merged commit d9847e6 into microsoft:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelfeldman @coveralls @mxschmitt