Skip to content

feat(roll): roll Playwright to 1.2.0-next.1595486491367 #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2020

Conversation

mxschmitt
Copy link
Member

No description provided.

@mxschmitt mxschmitt marked this pull request as ready for review July 23, 2020 19:00
@coveralls
Copy link

coveralls commented Jul 23, 2020

Pull Request Test Coverage Report for Build 180235607

  • 68 of 71 (95.77%) changed or added relevant lines in 10 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.09%) to 81.393%

Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/accessibility.py 19 20 95.0%
playwright/js_handle.py 15 17 88.24%
Files with Coverage Reduction New Missed Lines %
playwright/helper.py 1 86.23%
playwright/js_handle.py 1 91.82%
playwright/sync.py 1 59.11%
playwright/page.py 3 92.12%
Totals Coverage Status
Change from base Build 180117645: -0.09%
Covered Lines: 2139
Relevant Lines: 2628

💛 - Coveralls

@@ -53,7 +53,10 @@ def method(self) -> str:

@property
def postData(self) -> Optional[str]:
return self._initializer["postData"]
b64_content = self._initializer.get("postData")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also expose postDataBuffer as in TS, returning bytes.

@pavelfeldman pavelfeldman merged commit 767d41b into microsoft:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants