feat(test-runner): use require to resolve reporters #7749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Jul 20, 2021
types/test.d.ts
Outdated
| @@ -213,7 +213,7 @@ interface ConfigBase { | |||
| * It is possible to pass multiple reporters. A common pattern is using one terminal reporter | |||
| * like `'line'` or `'list'`, and one file reporter like `'json'` or `'junit'`. | |||
| */ | |||
| reporter?: 'dot' | 'line' | 'list' | 'junit' | 'json' | 'null' | ReporterDescription[]; | |||
| reporter?: string | ReporterDescription[]; | |||
There was a problem hiding this comment.
It was explicit before so that autocomplete works. Now it will not suggest builtin reporters, unfortunately.
What if we force reporter: ['my-reporter-module'] for third-party reporters instead?
There was a problem hiding this comment.
I brought back the autocomplete.
dgozman
approved these changes
Jul 20, 2021
JoelEinbinder
added a commit
to JoelEinbinder/playwright-1
that referenced
this pull request
Jul 21, 2021
JoelEinbinder
added a commit
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We import four different kinds of files:
config - has some very custom logic around folders and playwright.config.js
globalSetup/globalTeardown - Surprisingly allows relative paths without
./tests - custom logic with matches
reporters - updated in this patch to use require.resolve
I can update globalSetup/globalTeardown to use require.resolve. I think
it is a bug that they accept relative paths without
./. But it would bea breaking change, so I'll do it in another patch.