Don't use Uri.Empty for default workspace. #7654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heejaechang
force-pushed
the
defaultWorkspaceExtraPath
branch
from
2624b21 to
d4fb153
Compare
This comment has been minimized.
This comment has been minimized.
heejaechang
force-pushed
the
defaultWorkspaceExtraPath
branch
from
d4fb153 to
bb02af1
Compare
This comment has been minimized.
This comment has been minimized.
debonte
reviewed
Apr 10, 2024
heejaechang
force-pushed
the
defaultWorkspaceExtraPath
branch
from
bb02af1 to
6f60b33
Compare
This comment has been minimized.
This comment has been minimized.
heejaechang
force-pushed
the
defaultWorkspaceExtraPath
branch
from
6f60b33 to
e918b85
Compare
This comment has been minimized.
This comment has been minimized.
heejaechang
force-pushed
the
defaultWorkspaceExtraPath
branch
from
e918b85 to
398f886
Compare
This comment has been minimized.
This comment has been minimized.
heejaechang
force-pushed
the
defaultWorkspaceExtraPath
branch
from
398f886 to
4702f26
Compare
rchiodo
approved these changes
Apr 17, 2024
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pylance-release#5740
It broke due to this change https://github.com/microsoft/pyrx/pull/4878
During this update, we modified how Uri handles case sensitivity, identifying a specific problem where an
EmptyUriwas defaulting to case sensitivity: false.However,
EmptyUriimplemented functions like resolvePaths/combinePaths that ended up using incorrect case sensitivity. To address this, we changed howEmptyUribehaves and changed the default workspace not to useEmptyUri. However, it appears that we missed its usage in this spot.