Skip to content

Improve code sample by formatting the code, and including some code cleanups #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 24, 2018

Conversation

nnja
Copy link
Contributor

@nnja nnja commented Sep 21, 2018

Improved the sample code by making the following updated:

  • Removed a user-specific file from the .vscode folder and added it to .gitignore
  • PEP8ified and formatted the code, standardized use of double quote " throughout code files
  • Formatted the templates
  • Removed an errant print statement
  • Formatted the imports, removed relative imports in favor of absolute imports
  • Pulled out a variable in hello\urls.py to make the code cleaner
  • Use __str__ instead of __unicode__ for representing models in Django using Python3. Fixed variables. Since the tutorial is targeted for python 3.6, changed the return value to an f string.

A PR to update the docs based on these changes is located here: microsoft/vscode-docs#1869

@nnja
Copy link
Contributor Author

nnja commented Sep 21, 2018

cc/ @kraigb for review

@nnja nnja force-pushed the sample_repo_cleanup branch from af844a6 to 2ad7c56 Compare September 21, 2018 00:45
@kraigb kraigb merged commit 5b0ee51 into microsoft:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants