Respect configured target profile for histogram in VS Code #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the call to `run` to that is used by the histogram feature to take the current target profile, such that histograms in the VS Code extension correctly compile the code with the configured target.
swernli
requested review from
billti,
cesarzc,
sezna,
idavis and
minestarks
as code owners
10 tasks
Benchmark for e2e8605Click to view benchmark
|
billti
reviewed
May 23, 2024
billti
reviewed
May 23, 2024
billti
approved these changes
May 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
This is in preparation for the package work, but I think it's a useful refactor in its own right. No behavior changes. There are quite a few features/commands across the VS Code extension* that are meant to operate on the "currently active Q# project". This is defined as the Q# document in the currently active editor, and if that document is associated with a qsharp.json, the entire project. This code was duplicated across all these commands, and was slightly different everywhere. There have been bugs where we weren't respecting some of the common settings (e.g. #1565) and changes where we had to update each command separately if we changed something about project semantics (e.g. #1089, #918) . This PR aims to unify all that so we touch fewer places when we change something about the project compiler configuration logic. *Run, Debug, Circuit, Estimate, Histogram commands, Show Documentation, Get QIR and Submit to Azure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the call to
runto that is used by the histogram feature to take the current target profile, such that histograms in the VS Code extension correctly compile the code with the configured target.