This repository was archived by the owner on May 20, 2025. It is now read-only.
Removing JS bundle modified date mutation #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
lostintangent
added a commit
that referenced
this pull request
Feb 25, 2016
Removing JS bundle modified date mutation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the logic which explicitly sets the modified date of the JS bundle file when installing a ZIP update. This behavior was originally needed to determine precedence between a CodePush update and the binary contents, but we actually stopped relying on this a while ago, and therefore, it isn't necessary.
Additionally, this behavior causes an issue when the user releases an update whose JS bundle is read-only, and therefore, we can't mutate. By removing this logic, we can accommodate that scenario.