Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

sergey-akhalkov
Copy link
Contributor

…hapters

CodePush updates should be tested in modes other than Debug due to in Debug mode React Native app always downloads JS bundle generated by packager, so JS bundle downloaded by CodePush does not apply.

Relates #614 and #682

@msftclas
Copy link

msftclas commented Feb 7, 2017

Hi @sergey-akhalkov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Sergey Akhalkov (Akvelon)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@sergey-akhalkov sergey-akhalkov changed the title readme: improved “Releasing Updates” and “Multi-Deployment Testing” c… [docs][android] readme: improved “Releasing Updates” and “Multi-Deployment Testing” c… Feb 7, 2017
Copy link
Contributor

@buptkang buptkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+*NOTE: CodePush updates should be tested in modes other than Debug mode. In Debug mode, React Native app always downloads JS bundle generated by packager, so JS bundle downloaded by CodePush does not apply.

…hapters

CodePush updates should be tested in modes other than Debug due to in Debug mode React Native app always downloads JS bundle generated by packager, so JS bundle downloaded by CodePush does not apply.

Relates #614 and #682
@sergey-akhalkov
Copy link
Contributor Author

sergey-akhalkov commented Feb 7, 2017

@buptkang, thank you, I've applied the correction

@buptkang buptkang merged commit 3da57cd into microsoft:master Feb 7, 2017
@sergey-akhalkov sergey-akhalkov deleted the issue862 branch February 7, 2017 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants