-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): populate home screen with AppRegistry entries #1127
Conversation
4a6eb9f
to
a22d262
Compare
a03e388
to
f5ebb75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
-
❌ 0.64 (no libjsi.so)
- fails on
yarn android
with errorreact-native-test-app/example/node_modules/react-native-test-app/android/app/src/main/java/com/microsoft/reacttestapp/react/TestAppReactNativeHost.kt: (181, 24): Unresolved reference: loadLibrary
andExecution failed for task ':app:compileDebugKotlin'. > A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction > Compilation error. See log for more details
- fails on
-
✅ 0.68 (has release libjsi.so)
-
✅🟡 0.69 (has debug/release libjsi.so) (but for some reason it just shows a blank page instead of the normal one with all the info, and just the version in the bottom right corner)
-
❌ 0.69 + new arch (uses ndkBuild, libjsi.so already linked)
- fails on
yarn android
with errorreact-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk: No such file or directory
andmake: *** No rule to make target '/Users/lsciandra/Developer/oss/react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk'. Stop.
- fails on
-
✅ 0.70 (has debug/release libjsi.so)
-
✅ 0.70 + new arch (uses cmake, libjsi.so already linked)
370b72c
to
5357a81
Compare
f5ebb75
to
4e34251
Compare
yeah, with the adjustments I managed to make it work for both 0.64 and both versions of 0.69 🎉 LGTM, when you want to open for review I can ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4e34251
to
20eb037
Compare
Description
Similar to #482, but for Android.
Resolves #189.
Platforms affected
Test plan
See test plan in #482.
Flipper crashes on startup with this change. I'm not sure why, but downgrading it to 0.105 resolves the issue.TheSIGILL
comes from the device trying to load different.so
files on startup, but the app should load fine. Bump to 0.164 to make it go away.This needs to be tested on:
libjsi.so
, should show blank screen)libjsi.so
)libjsi.so
)ndkBuild
,libjsi.so
already linked)libjsi.so
)cmake
,libjsi.so
already linked)Note that for new arch, you will need to force resolve rn-cli to 9.x for autolinking.