[rush-lib] Set default max install attempts to 1 #3495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowadays, most of the time when an install fails, it is due to a reason that won't be solved by just rerunning, but needs to be fixed by the dev.
dbartholomae
requested review from
iclanton,
octogonz,
apostolisms and
D4N14L
as code owners
iclanton
approved these changes
Jun 27, 2022
octogonz
pushed a commit
to octogonz/rushstack
that referenced
this pull request
Jul 5, 2022
…nstall-attempts_to_1 [rush-lib] Set default max install attempts to 1
chengcyber
pushed a commit
to chengcyber/rushstack
that referenced
this pull request
Jul 20, 2022
…nstall-attempts_to_1 [rush-lib] Set default max install attempts to 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now, rush update by default retries 3 times before failing. That is problematic, as most of the time it fails, it fails for a good reason that won't go away when retrying (e.g. missing peerDeps or mismatching versions).
Fixes #3482
Details
I reduced the max install attempts to 1.
How it was tested
There's a snapshot test that changed.