Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxing GH1005 #2248

Merged
merged 7 commits into from
Jan 22, 2021
Merged

Relaxing GH1005 #2248

merged 7 commits into from
Jan 22, 2021

Conversation

eddynaka
Copy link
Collaborator

Fixes #2197

@lgtm-com
Copy link

lgtm-com bot commented Jan 19, 2021

This pull request introduces 1 alert when merging f3f1b95 into 9d1f33d - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

Copy link
Contributor

@marcogario marcogario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelcfanning michaelcfanning enabled auto-merge (squash) January 22, 2021 22:37
@michaelcfanning michaelcfanning merged commit 2442b67 into main Jan 22, 2021
@michaelcfanning michaelcfanning deleted the users/ednakamu/relaxing-gh1005 branch January 22, 2021 23:01
@eddynaka eddynaka mentioned this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax GH1005
3 participants