Weaviate: Fix to be compatible with python 3.8 #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
hsm207
changed the title
Hypothesis: server doesn't like it when you send too many requests per second Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
…7/semantic-kernel into tests-weaviate-integration
python/tests/integration/connectors/memory/test_weaviate_memory_store.py
Outdated
Show resolved
Hide resolved
awharrison-28
requested changes
Jun 5, 2023
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
done! |
awharrison-28
approved these changes
Jun 6, 2023
dluc
approved these changes
Jun 6, 2023
salmon131
pushed a commit
to salmon131/semantic-kernel
that referenced
this pull request
Jun 7, 2023
use run_in_executor instead of to_thread to run the weaviate client ops in async because to_thread is not available in python 3.8
Merged
dluc
added a commit
that referenced
this pull request
Jun 12, 2023
* [e4781e5] Add sample notebook to demo weaviate memory store (#1359) * [dae1c16] Python: Added examples of using ChatCompletion models for skill building in Jupyter Notebooks (#1242) * [f4e92eb] fix: Add Azure OpenAI support for python/08-native-function-inline (#1365) * [de74668] Fixing typos (#1377) * [67aa732] Python: Fix weaviate integration tests (#1422) * [f60d7ba] Fix functions_view.py (#1213) * [b2e1548] Python: Multiple results per prompt (incl. streaming) (#1316) * [4c4670a] Using dotenv instead of parsing keys ourselves (#1295) * [05d9e72] Python: Sync pyproject.toml with requirements.txt (#1150) * [6cbea85] Python: Add additional_metadata field to MemoryRecord and address TODOs in ChromaMemoryStore (#1323) * [8947e68] Weaviate: Fix to be compatible with python 3.8 (#1349)
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
use run_in_executor instead of to_thread to run the weaviate client ops in async because to_thread is not available in python 3.8
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
* [e4781e5] Add sample notebook to demo weaviate memory store (microsoft#1359) * [dae1c16] Python: Added examples of using ChatCompletion models for skill building in Jupyter Notebooks (microsoft#1242) * [f4e92eb] fix: Add Azure OpenAI support for python/08-native-function-inline (microsoft#1365) * [de74668] Fixing typos (microsoft#1377) * [67aa732] Python: Fix weaviate integration tests (microsoft#1422) * [f60d7ba] Fix functions_view.py (microsoft#1213) * [b2e1548] Python: Multiple results per prompt (incl. streaming) (microsoft#1316) * [4c4670a] Using dotenv instead of parsing keys ourselves (microsoft#1295) * [05d9e72] Python: Sync pyproject.toml with requirements.txt (microsoft#1150) * [6cbea85] Python: Add additional_metadata field to MemoryRecord and address TODOs in ChromaMemoryStore (microsoft#1323) * [8947e68] Weaviate: Fix to be compatible with python 3.8 (microsoft#1349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
use run_in_executor instead of to_thread to run the weaviate client ops in async because to_thread is not available in 3.8
Contribution Checklist
dotnet format