Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typos #1377

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Fixing typos #1377

merged 2 commits into from
Jun 8, 2023

Conversation

lemillermicrosoft
Copy link
Member

@lemillermicrosoft lemillermicrosoft commented Jun 8, 2023 •
edited
Loading

Motivation and Context

Fixing typos to unblock PRs.

Contribution Checklist

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code samples labels Jun 8, 2023
@lemillermicrosoft lemillermicrosoft added PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed PR: ready to merge PR has been approved by all reviewers, and is ready to merge. PR: ready for review All feedback addressed, ready for reviews labels Jun 8, 2023
adrianwyatt
adrianwyatt previously approved these changes Jun 8, 2023
View reviewed changes
@adrianwyatt adrianwyatt self-assigned this Jun 8, 2023
@adrianwyatt adrianwyatt added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Jun 8, 2023
@lemillermicrosoft
✨Add ags to typos extend-identifiers
333ff1c 
This commit adds ags as an extended identifier to the _typos.toml
file, which is used by the typos action to check for spelling errors
in the repository. This prevents the action from flagging ags as a
typo, since it is an acronym for Azure Graph Service.
@lemillermicrosoft
fix typos
d3e3598
@adrianwyatt adrianwyatt enabled auto-merge (squash) June 8, 2023 17:38
@adrianwyatt adrianwyatt merged commit de74668 into microsoft:main Jun 8, 2023
16 checks passed
@lemillermicrosoft lemillermicrosoft mentioned this pull request Jun 8, 2023
Merged
5 tasks
@mattmazzola mattmazzola mentioned this pull request Jun 8, 2023
Closed
5 tasks
lemillermicrosoft added a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 8, 2023
@lemillermicrosoft
Squashed commit of the following:
6aec90a 
commit d3775b0
Author: Matt Mazzola <mattm@microsoft.com>
Date:   Thu Jun 8 12:43:17 2023 -0700

    style: chat-summary-webapp-react - change label for deployment form input from Model to Deployment (microsoft#1368)

    There are different sets of parameters when using OpenAI vs Azure OpenAI

    1. OpenAI Key
    1. Model (`text-davinci-003`)
    You can deploy multiple versions of the same model (`gpt-3.5-turbo`)
    with different resource throughput. This is why "model" is not unique
    enough. Instead of Model you specify Deployment and Endpoint

    1. OpenAI Key
    1. Deployment
    1. Endpoint

    The `samples\apps\chat-summary-webapp-react` it was using Model term
    which may be misleading

    - samples\apps\chat-summary-webapp-react
        - Change label for Deployment form input from Model to Deployment

commit 1a7639a
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Jun 8 18:13:30 2023 +0000

    Bump PdfPig from 0.1.8-alpha-20230423-3898f to 0.1.8-alpha-20230529-6daa2 in /dotnet (microsoft#1267)

    Bumps [PdfPig](https://github.com/UglyToad/PdfPig) from
    0.1.8-alpha-20230423-3898f to 0.1.8-alpha-20230529-6daa2.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a
    href="https://github.com/UglyToad/PdfPig/releases">PdfPig's
    releases</a>.</em></p>
    <blockquote>
    <h2>0.1.2 Second Alpha</h2>
    <p>Adds letter font details and a couple of other bugfixes to the alpha
    version.</p>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li>See full diff in <a
    href="https://github.com/UglyToad/PdfPig/commits">compare view</a></li>
    </ul>
    </details>
    <br />

    [![Dependabot compatibility
    score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=PdfPig&package-manager=nuget&previous-version=0.1.8-alpha-20230423-3898f&new-version=0.1.8-alpha-20230529-6daa2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.

    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)

    ---

    <details>
    <summary>Dependabot commands and options</summary>
    <br />

    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits
    that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after
    your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge
    and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating
    it. You can achieve the same result by closing it manually
    - `@dependabot ignore this major version` will close this PR and stop
    Dependabot creating any more for this major version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop
    Dependabot creating any more for this minor version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop
    Dependabot creating any more for this dependency (unless you reopen the
    PR or upgrade to it yourself)

    </details>

    ---------

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>

commit 729d9d7
Author: garethdebruyn <garethdebruyn@users.noreply.github.com>
Date:   Thu Jun 8 19:47:22 2023 +0200

    Update Example02_Pipeline.cs (microsoft#1286)

    text["LStrip"], text["RStrip"] no longer seem to be part of TextSkill

commit de74668
Author: Lee Miller <lemiller@microsoft.com>
Date:   Thu Jun 8 10:41:02 2023 -0700

    Fixing typos (microsoft#1377)
    Fixing typos to unblock PRs.

commit 3bc0967
Author: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Date:   Thu Jun 8 17:29:52 2023 +0100

    IChatCompletion Multiple Results / New Interfaces (microsoft#1117)

    Add potential for IChatCompletion with multiple results per prompt.

    ![MultiChatResultPR](https://github.com/microsoft/semantic-kernel/assets/19890735/725ecce9-5e22-4a46-a06d-b159c68807f0)

    - Adds new Interfaces/Abstractions for Chat Results: `IChatResult`,
    `IChatStreamingResult`, `IChatMessage`
    - Adds new `IChatCompletion` interface methods for Streaming and
    Non-Streaming results
    - Moves old `IChatCompletion` interface methods
    `IAsyncEnumerable<string> GenerateMessageStreamAsync` and `Task<string>
    GenerateMessageAsync` as extensions for retro compatibility
    - Changed `ChatAsText` to use the new multiple results implementations
    - Makes `ChatHistory.ChatMessage` & `ChatHistory.AuthorsRole` types
    obsolete (discouraging usage of those implementation in favor of new
    `IChatMessage`
    - `ChatHistory` abstraction now extends from `List<IChatMessage>`
    - Updates all Samples using the new interfaces.
    - Remove `ChatHistory.ChatMessage` inner class
    - Remove `ChatHistory.AuthorsRole` enums
    - Make `ChatHistory` an abstract class or an `IChatHistory` interface.
    - Rename `ITextCompletionResult` to `ITextResult`
    - Rename `ITextComplet
@dluc dluc mentioned this pull request Jun 12, 2023
Merged
dluc added a commit that referenced this pull request Jun 12, 2023
@dluc
New python release (#1425)
774254f 
* [e4781e5] Add sample notebook to demo weaviate memory store (#1359)
* [dae1c16] Python: Added examples of using ChatCompletion models for
skill building in Jupyter Notebooks (#1242)
* [f4e92eb] fix: Add Azure OpenAI support for
python/08-native-function-inline (#1365)
* [de74668] Fixing typos (#1377)
* [67aa732] Python: Fix weaviate integration tests (#1422)
* [f60d7ba] Fix functions_view.py (#1213)
* [b2e1548] Python: Multiple results per prompt (incl. streaming)
(#1316)
* [4c4670a] Using dotenv instead of parsing keys ourselves (#1295)
* [05d9e72] Python: Sync pyproject.toml with requirements.txt (#1150)
* [6cbea85] Python: Add additional_metadata field to MemoryRecord and
address TODOs in ChromaMemoryStore (#1323)
* [8947e68] Weaviate: Fix to be compatible with python 3.8 (#1349)
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@lemillermicrosoft
Fixing typos (microsoft#1377)
c889f57 
### Motivation and Context
Fixing typos to unblock PRs.
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@dluc
New python release (microsoft#1425)
95a939e 
* [e4781e5] Add sample notebook to demo weaviate memory store (microsoft#1359)
* [dae1c16] Python: Added examples of using ChatCompletion models for
skill building in Jupyter Notebooks (microsoft#1242)
* [f4e92eb] fix: Add Azure OpenAI support for
python/08-native-function-inline (microsoft#1365)
* [de74668] Fixing typos (microsoft#1377)
* [67aa732] Python: Fix weaviate integration tests (microsoft#1422)
* [f60d7ba] Fix functions_view.py (microsoft#1213)
* [b2e1548] Python: Multiple results per prompt (incl. streaming)
(microsoft#1316)
* [4c4670a] Using dotenv instead of parsing keys ourselves (microsoft#1295)
* [05d9e72] Python: Sync pyproject.toml with requirements.txt (microsoft#1150)
* [6cbea85] Python: Add additional_metadata field to MemoryRecord and
address TODOs in ChromaMemoryStore (microsoft#1323)
* [8947e68] Weaviate: Fix to be compatible with python 3.8 (microsoft#1349)
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
@lemillermicrosoft
Fixing typos (microsoft#1377)
d849e5c 
### Motivation and Context
Fixing typos to unblock PRs.
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
@lemillermicrosoft
Fixing typos (microsoft#1377)
1a779f8 
### Motivation and Context
Fixing typos to unblock PRs.
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
@lemillermicrosoft
Fixing typos (microsoft#1377)
5ac1a33 
### Motivation and Context
Fixing typos to unblock PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianwyatt adrianwyatt adrianwyatt approved these changes

Assignees

@adrianwyatt adrianwyatt

Labels
.NET Issue or Pull requests regarding .NET code PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lemillermicrosoft @adrianwyatt