Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample notebook to demo weaviate memory store #1359

Merged
merged 15 commits into from
Jun 10, 2023

Conversation

hsm207
Copy link
Contributor

@hsm207 hsm207 commented Jun 7, 2023

Motivation and Context

  1. Why is this change required?
    To show users how to use the WeaviateMemoryStore memory store
  2. What problem does it solve?
    Users don't know how to config and use the WeaviateMemoryStore memory store
  3. What scenario does it contribute to?
    Users want to learn how to config and use the WeaviateMemoryStore memory store
  4. If it fixes an open issue, please link to the issue here.
    NA

Description

Add a notebook to show users how to config and use the WeaviateMemoryStore memory store in a few examples.

Contribution Checklist

@alexchaomander
Copy link
Contributor

@hsm207 Thank you for this PR! Can you create this under samples/notebooks/python/third_party

And rename this to weaviate-persistent-memory.ipynb?

We want to start highlighting examples coming from other open-source projects and put them in their own location.

@awharrison-28 @mkarle

@hsm207
Copy link
Contributor Author

hsm207 commented Jun 7, 2023

@hsm207 Thank you for this PR! Can you create this under samples/notebooks/python/third_party

And rename this to weaviate-persistent-memory.ipynb?

@alexchaomander done!

@hsm207 hsm207 marked this pull request as ready for review June 7, 2023 14:52
@hsm207
Copy link
Contributor Author

hsm207 commented Jun 7, 2023

@alexchaomander @awharrison-28 this PR is ready for review

Copy link
Contributor

@awharrison-28 awharrison-28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool and I got it up and running on Windows + Docker fairly quickly!

In addition to the other comments:

Please add the following block in the setup code

!pip install semantic-kernel==0.3.0.dev0
!pip install weaviate-client
!pip install python-dotenv

@hsm207
Copy link
Contributor Author

hsm207 commented Jun 7, 2023

Please add the following block in the setup code

done!

@hsm207
Copy link
Contributor Author

hsm207 commented Jun 8, 2023

@awharrison-28 @alexchaomander we've addressed all your feedback

Copy link
Contributor

@awharrison-28 awharrison-28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsm207
Copy link
Contributor Author

hsm207 commented Jun 9, 2023

@alexchaomander just pending your review 馃榾

Copy link
Contributor

@alexchaomander alexchaomander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for adding this example!

@alexchaomander alexchaomander added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Jun 9, 2023
@hsm207
Copy link
Contributor Author

hsm207 commented Jun 9, 2023

@alexchaomander thanks for the review. does this still need someone else's approval? The status of the actions is "6 workflows awaiting approval, This workflow requires approval from a maintainer".

@alexchaomander
Copy link
Contributor

@alexchaomander thanks for the review. does this still need someone else's approval? The status of the actions is "6 workflows awaiting approval, This workflow requires approval from a maintainer".

Nothing else from your side! Our team will work to merge this in today!

@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) June 9, 2023 16:15
@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) June 9, 2023 16:16
@lemillermicrosoft lemillermicrosoft merged commit e4781e5 into microsoft:main Jun 10, 2023
23 of 26 checks passed
@dluc dluc mentioned this pull request Jun 12, 2023
dluc added a commit that referenced this pull request Jun 12, 2023
* [e4781e5] Add sample notebook to demo weaviate memory store (#1359)
* [dae1c16] Python: Added examples of using ChatCompletion models for
skill building in Jupyter Notebooks (#1242)
* [f4e92eb] fix: Add Azure OpenAI support for
python/08-native-function-inline (#1365)
* [de74668] Fixing typos (#1377)
* [67aa732] Python: Fix weaviate integration tests (#1422)
* [f60d7ba] Fix functions_view.py (#1213)
* [b2e1548] Python: Multiple results per prompt (incl. streaming)
(#1316)
* [4c4670a] Using dotenv instead of parsing keys ourselves (#1295)
* [05d9e72] Python: Sync pyproject.toml with requirements.txt (#1150)
* [6cbea85] Python: Add additional_metadata field to MemoryRecord and
address TODOs in ChromaMemoryStore (#1323)
* [8947e68] Weaviate: Fix to be compatible with python 3.8 (#1349)
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
### Motivation and Context
  1. Why is this change required?
      To show users how to use the WeaviateMemoryStore memory store
  2. What problem does it solve?
Users don't know how to config and use the WeaviateMemoryStore memory
store
  3. What scenario does it contribute to?
Users want to learn how to config and use the WeaviateMemoryStore memory
store
  4. If it fixes an open issue, please link to the issue here.
      NA

### Description
Add a notebook to show users how to config and use the
WeaviateMemoryStore memory store in a few examples.
---------

Co-authored-by: Dan Dascalescu <dan@weaviate.io>
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
* [e4781e5] Add sample notebook to demo weaviate memory store (microsoft#1359)
* [dae1c16] Python: Added examples of using ChatCompletion models for
skill building in Jupyter Notebooks (microsoft#1242)
* [f4e92eb] fix: Add Azure OpenAI support for
python/08-native-function-inline (microsoft#1365)
* [de74668] Fixing typos (microsoft#1377)
* [67aa732] Python: Fix weaviate integration tests (microsoft#1422)
* [f60d7ba] Fix functions_view.py (microsoft#1213)
* [b2e1548] Python: Multiple results per prompt (incl. streaming)
(microsoft#1316)
* [4c4670a] Using dotenv instead of parsing keys ourselves (microsoft#1295)
* [05d9e72] Python: Sync pyproject.toml with requirements.txt (microsoft#1150)
* [6cbea85] Python: Add additional_metadata field to MemoryRecord and
address TODOs in ChromaMemoryStore (microsoft#1323)
* [8947e68] Weaviate: Fix to be compatible with python 3.8 (microsoft#1349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants