-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample notebook to demo weaviate memory store #1359
Conversation
@hsm207 Thank you for this PR! Can you create this under And rename this to We want to start highlighting examples coming from other open-source projects and put them in their own location. |
@alexchaomander done! |
@alexchaomander @awharrison-28 this PR is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool and I got it up and running on Windows + Docker fairly quickly!
In addition to the other comments:
Please add the following block in the setup code
!pip install semantic-kernel==0.3.0.dev0
!pip install weaviate-client
!pip install python-dotenv
samples/notebooks/python/third_party/weaviate-persistent-memory.ipynb
Outdated
Show resolved
Hide resolved
samples/notebooks/python/third_party/weaviate-persistent-memory.ipynb
Outdated
Show resolved
Hide resolved
done! |
@awharrison-28 @alexchaomander we've addressed all your feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alexchaomander just pending your review 馃榾 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for adding this example!
@alexchaomander thanks for the review. does this still need someone else's approval? The status of the actions is "6 workflows awaiting approval, This workflow requires approval from a maintainer". |
Nothing else from your side! Our team will work to merge this in today! |
* [e4781e5] Add sample notebook to demo weaviate memory store (#1359) * [dae1c16] Python: Added examples of using ChatCompletion models for skill building in Jupyter Notebooks (#1242) * [f4e92eb] fix: Add Azure OpenAI support for python/08-native-function-inline (#1365) * [de74668] Fixing typos (#1377) * [67aa732] Python: Fix weaviate integration tests (#1422) * [f60d7ba] Fix functions_view.py (#1213) * [b2e1548] Python: Multiple results per prompt (incl. streaming) (#1316) * [4c4670a] Using dotenv instead of parsing keys ourselves (#1295) * [05d9e72] Python: Sync pyproject.toml with requirements.txt (#1150) * [6cbea85] Python: Add additional_metadata field to MemoryRecord and address TODOs in ChromaMemoryStore (#1323) * [8947e68] Weaviate: Fix to be compatible with python 3.8 (#1349)
### Motivation and Context 1. Why is this change required? To show users how to use the WeaviateMemoryStore memory store 2. What problem does it solve? Users don't know how to config and use the WeaviateMemoryStore memory store 3. What scenario does it contribute to? Users want to learn how to config and use the WeaviateMemoryStore memory store 4. If it fixes an open issue, please link to the issue here. NA ### Description Add a notebook to show users how to config and use the WeaviateMemoryStore memory store in a few examples. --------- Co-authored-by: Dan Dascalescu <dan@weaviate.io>
* [e4781e5] Add sample notebook to demo weaviate memory store (microsoft#1359) * [dae1c16] Python: Added examples of using ChatCompletion models for skill building in Jupyter Notebooks (microsoft#1242) * [f4e92eb] fix: Add Azure OpenAI support for python/08-native-function-inline (microsoft#1365) * [de74668] Fixing typos (microsoft#1377) * [67aa732] Python: Fix weaviate integration tests (microsoft#1422) * [f60d7ba] Fix functions_view.py (microsoft#1213) * [b2e1548] Python: Multiple results per prompt (incl. streaming) (microsoft#1316) * [4c4670a] Using dotenv instead of parsing keys ourselves (microsoft#1295) * [05d9e72] Python: Sync pyproject.toml with requirements.txt (microsoft#1150) * [6cbea85] Python: Add additional_metadata field to MemoryRecord and address TODOs in ChromaMemoryStore (microsoft#1323) * [8947e68] Weaviate: Fix to be compatible with python 3.8 (microsoft#1349)
Motivation and Context
To show users how to use the WeaviateMemoryStore memory store
Users don't know how to config and use the WeaviateMemoryStore memory store
Users want to learn how to config and use the WeaviateMemoryStore memory store
NA
Description
Add a notebook to show users how to config and use the WeaviateMemoryStore memory store in a few examples.
Contribution Checklist
dotnet format