Fix functions_view.py #1213
Merged
Fix functions_view.py #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding this! The team will review soon! |
|
closes #1212 @salmon131 would you mind turning the examples you demonstrated in the above issue into unit tests? |
github-actions
bot
added
.NET
github-actions
bot
removed
.NET
|
@microsoft-github-policy-service agree company="ascentkorea" |
|
@awharrison-28 |
|
to fix the linting issue, run I tried to do it myself, but I hit an issue pushing to this PR. |
github-actions
bot
added
.NET
github-actions
bot
removed
samples
kernel
|
@awharrison-28 |
Looks like you'll need to do |
|
@awharrison-28 |
awharrison-28
approved these changes
Jun 9, 2023
Merged
dluc
added a commit
that referenced
this pull request
Jun 12, 2023
* [e4781e5] Add sample notebook to demo weaviate memory store (#1359) * [dae1c16] Python: Added examples of using ChatCompletion models for skill building in Jupyter Notebooks (#1242) * [f4e92eb] fix: Add Azure OpenAI support for python/08-native-function-inline (#1365) * [de74668] Fixing typos (#1377) * [67aa732] Python: Fix weaviate integration tests (#1422) * [f60d7ba] Fix functions_view.py (#1213) * [b2e1548] Python: Multiple results per prompt (incl. streaming) (#1316) * [4c4670a] Using dotenv instead of parsing keys ourselves (#1295) * [05d9e72] Python: Sync pyproject.toml with requirements.txt (#1150) * [6cbea85] Python: Add additional_metadata field to MemoryRecord and address TODOs in ChromaMemoryStore (#1323) * [8947e68] Weaviate: Fix to be compatible with python 3.8 (#1349)
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context microsoft#1212 ### Description Fixed a bug in the process of checking native function. --------- Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com> Co-authored-by: Devis Lucato <dluc@users.noreply.github.com>
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
* [e4781e5] Add sample notebook to demo weaviate memory store (microsoft#1359) * [dae1c16] Python: Added examples of using ChatCompletion models for skill building in Jupyter Notebooks (microsoft#1242) * [f4e92eb] fix: Add Azure OpenAI support for python/08-native-function-inline (microsoft#1365) * [de74668] Fixing typos (microsoft#1377) * [67aa732] Python: Fix weaviate integration tests (microsoft#1422) * [f60d7ba] Fix functions_view.py (microsoft#1213) * [b2e1548] Python: Multiple results per prompt (incl. streaming) (microsoft#1316) * [4c4670a] Using dotenv instead of parsing keys ourselves (microsoft#1295) * [05d9e72] Python: Sync pyproject.toml with requirements.txt (microsoft#1150) * [6cbea85] Python: Add additional_metadata field to MemoryRecord and address TODOs in ChromaMemoryStore (microsoft#1323) * [8947e68] Weaviate: Fix to be compatible with python 3.8 (microsoft#1349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#1212
Description
Fixed a bug in the process of checking native function.
Contribution Checklist
dotnet format